From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89D8FC433DB for ; Thu, 7 Jan 2021 13:47:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52CBB2333E for ; Thu, 7 Jan 2021 13:47:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728427AbhAGNqx (ORCPT ); Thu, 7 Jan 2021 08:46:53 -0500 Received: from mga01.intel.com ([192.55.52.88]:46375 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728026AbhAGNqx (ORCPT ); Thu, 7 Jan 2021 08:46:53 -0500 IronPort-SDR: FEcQSqFVlH49vunK22pYRJG7TcS5NhDjo1u+a2X/KMkBainBQFciUDYaUc15T42b8UG3ks/MGR n8xr+V8B/6dA== X-IronPort-AV: E=McAfee;i="6000,8403,9856"; a="195982123" X-IronPort-AV: E=Sophos;i="5.79,329,1602572400"; d="scan'208";a="195982123" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2021 05:45:07 -0800 IronPort-SDR: Vw/7mPcxthNUBixNycZeCdAZ22z5w/+uDM+0bZhDdJfdHRQjBq94unP9jU4rl0YaQhlIEFRVa4 NQ3Bm8l2x4NQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,329,1602572400"; d="scan'208";a="463040716" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 07 Jan 2021 05:45:00 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Thu, 07 Jan 2021 15:45:00 +0200 Date: Thu, 7 Jan 2021 15:45:00 +0200 From: Heikki Krogerus To: Daniel Scally Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-media@vger.kernel.org, devel@acpica.org, rjw@rjwysocki.net, lenb@kernel.org, gregkh@linuxfoundation.org, mchehab@kernel.org, sergey.senozhatsky@gmail.com, yong.zhi@intel.com, sakari.ailus@linux.intel.com, bingbu.cao@intel.com, tian.shu.qiu@intel.com, robert.moore@intel.com, erik.kaneda@intel.com, pmladek@suse.com, rostedt@goodmis.org, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, laurent.pinchart+renesas@ideasonboard.com, jacopo+renesas@jmondi.org, kieran.bingham+renesas@ideasonboard.com, hverkuil-cisco@xs4all.nl, m.felsch@pengutronix.de, niklas.soderlund+renesas@ragnatech.se, prabhakar.mahadev-lad.rj@bp.renesas.com, slongerbeam@gmail.com, Laurent Pinchart Subject: Re: [PATCH v5 01/15] software_node: Fix refcounts in software_node_get_next_child() Message-ID: <20210107134500.GC940479@kuha.fi.intel.com> References: <20210107132838.396641-1-djrscally@gmail.com> <20210107132838.396641-2-djrscally@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210107132838.396641-2-djrscally@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 07, 2021 at 01:28:24PM +0000, Daniel Scally wrote: > The software_node_get_next_child() function currently does not hold > references to the child software_node that it finds or put the ref that > is held against the old child - fix that. > > Fixes: 59abd83672f7 ("drivers: base: Introducing software nodes to the firmware node framework") > Reviewed-by: Andy Shevchenko > Reviewed-by: Laurent Pinchart > Reviewed-by: Sakari Ailus > Signed-off-by: Daniel Scally Reviewed-by: Heikki Krogerus > --- > Changes in v5: > > - None > > drivers/base/swnode.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c > index 4a4b2008fbc2..4fcc1a6fb724 100644 > --- a/drivers/base/swnode.c > +++ b/drivers/base/swnode.c > @@ -443,14 +443,18 @@ software_node_get_next_child(const struct fwnode_handle *fwnode, > struct swnode *c = to_swnode(child); > > if (!p || list_empty(&p->children) || > - (c && list_is_last(&c->entry, &p->children))) > + (c && list_is_last(&c->entry, &p->children))) { > + fwnode_handle_put(child); > return NULL; > + } > > if (c) > c = list_next_entry(c, entry); > else > c = list_first_entry(&p->children, struct swnode, entry); > - return &c->fwnode; > + > + fwnode_handle_put(child); > + return fwnode_handle_get(&c->fwnode); > } > > static struct fwnode_handle * > -- > 2.25.1 thanks, -- heikki