mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Liu Yi L <yi.l.liu@intel.com>
Cc: baolu.lu@linux.intel.com, joro@8bytes.org, kevin.tian@intel.com,
	ashok.raj@intel.com, jun.j.tian@intel.com,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	yi.y.sun@intel.com, dan.carpenter@oracle.com,
	Xin Zeng <xin.zeng@intel.com>
Subject: Re: [PATCH v4 2/3] iommu/vt-d: Track device aux-attach with subdevice_domain_info
Date: Thu, 7 Jan 2021 13:49:07 +0000	[thread overview]
Message-ID: <20210107134906.GA3043@willie-the-truck> (raw)
In-Reply-To: <1609949037-25291-3-git-send-email-yi.l.liu@intel.com>

On Thu, Jan 07, 2021 at 12:03:56AM +0800, Liu Yi L wrote:
> In the existing code, loop all devices attached to a domain does not
> include sub-devices attached via iommu_aux_attach_device().
> 
> This was found by when I'm working on the below patch, There is no
> device in the domain->devices list, thus unable to get the cap and
> ecap of iommu unit. But this domain actually has subdevice which is
> attached via aux-manner. But it is tracked by domain. This patch is
> going to fix it.
> 
> https://lore.kernel.org/kvm/1599734733-6431-17-git-send-email-yi.l.liu@intel.com/
> 
> And this fix goes beyond the patch above, such sub-device tracking is
> necessary for other cases. For example, flushing device_iotlb for a
> domain which has sub-devices attached by auxiliary manner.

Sorry, but I'm having a really hard time understanding what this patch is
doing based on this commit message. Baolu -- do you think you could reword
it for me please? No need to resend the patch.

Thanks,

Will

  reply	other threads:[~2021-01-07 13:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06 16:03 [PATCH v4 0/3] iommu/vt-d: Misc fixes on scalable mode Liu Yi L
2021-01-06 16:03 ` [PATCH v4 1/3] iommu/vt-d: Move intel_iommu info from struct intel_svm to struct intel_svm_dev Liu Yi L
2021-01-06 16:03 ` [PATCH v4 2/3] iommu/vt-d: Track device aux-attach with subdevice_domain_info Liu Yi L
2021-01-07 13:49   ` Will Deacon [this message]
2021-01-07 14:16     ` Lu Baolu
2021-01-07 14:39       ` Will Deacon
2021-01-06 16:03 ` [PATCH v4 3/3] iommu/vt-d: Fix ineffective devTLB invalidation for subdevices Liu Yi L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210107134906.GA3043@willie-the-truck \
    --to=will@kernel.org \
    --cc=ashok.raj@intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=dan.carpenter@oracle.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=jun.j.tian@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xin.zeng@intel.com \
    --cc=yi.l.liu@intel.com \
    --cc=yi.y.sun@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®