From: Mark Brown <broonie@kernel.org>
To: Chris Chiu <chiu@endlessos.org>
Cc: oder_chiou@realtek.com, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, linux@endlessos.org
Subject: Re: [PATCH 1/4] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO
Date: Thu, 7 Jan 2021 14:27:46 +0000 [thread overview]
Message-ID: <20210107142746.GC4726@sirena.org.uk> (raw)
In-Reply-To: <20210107090625.107078-2-chiu@endlessos.org>
[-- Attachment #1: Type: text/plain, Size: 516 bytes --]
On Thu, Jan 07, 2021 at 05:06:22PM +0800, Chris Chiu wrote:
> +static const struct acpi_gpio_mapping *cht_rt5645_gpios;
> +
You're adding a read only static variable with no way to set it. This
doesn't actually do anything?
> @@ -3780,7 +3782,6 @@ static const struct dmi_system_id dmi_platform_data[] = {
> },
> .driver_data = (void *)&intel_braswell_platform_data,
> },
> - { }
> };
>
This is an unrelated change which removes the terminator on the array
which will cause issues.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-07 14:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 9:06 [PATCH 0/4] ASoC: rt5645: Enable internal mic and headset on ECS EF20 Chris Chiu
2021-01-07 9:06 ` [PATCH 1/4] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO Chris Chiu
2021-01-07 14:27 ` Mark Brown [this message]
2021-01-08 3:30 ` Chris Chiu
2021-01-07 9:06 ` [PATCH 2/4] ASoC: rt5645: Add ACPI-defined GPIO for ECS EF20 series Chris Chiu
2021-01-07 9:06 ` [PATCH 3/4] ASoC: rt5645: add inv_hp_det flag Chris Chiu
2021-01-07 9:06 ` [PATCH 4/4] ASoC: rt5645: Enable internal microphone and JD on ECS EF20 Chris Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107142746.GC4726@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=chiu@endlessos.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessos.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®