From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0751FC433E0 for ; Sat, 9 Jan 2021 01:02:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5E8523A7C for ; Sat, 9 Jan 2021 01:02:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726281AbhAIBBz (ORCPT ); Fri, 8 Jan 2021 20:01:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725916AbhAIBBy (ORCPT ); Fri, 8 Jan 2021 20:01:54 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48BC0C061757 for ; Fri, 8 Jan 2021 17:01:14 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id n205so17351518ybf.20 for ; Fri, 08 Jan 2021 17:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=2kvzi9/MXTZJcB1AsjglVBP3UVDn0xJjKk3dMI1v624=; b=VcHiHRV/86MH0/jN9gbnzQooC4E4wtdl5zD1RupCpcLQWXK8b5I0xyvN/IjgmF0xGD ROzuNdi36AWzQEUpYdtSAgnomHyMrC4ViICFIFdX6WfYnIb4lHDhZMXCuwDLpG6BBZJi GrIAxWe7K6yYmGJ9f7LTFeYcPrxY4qcaHsuaVcI90NHK3eOS5ctTPrcRNB/xmBwwbyxo vNSWXw7DKHAkBRgRDl+pBAkxSm/WrZiEe9carLgI2OITduI3JdM87N2qJLCiM04sjQoP 6Wa+TnLX1sTYpACZx/E2Z6ZcFBPkbqKjfi+nj7+9RSgT3B+0D7Z+Xi7n34LfeORUfy7A EkAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=2kvzi9/MXTZJcB1AsjglVBP3UVDn0xJjKk3dMI1v624=; b=cHelVpL3pmO3uW+525mAUrbOaIGKOKlHbht8yIERs9z/UBtvwff+gxCqq6BC/29Wpo t+FB1Te343YjxjWn1izdCnf4LQ0hDZGk5c5pEF7Z1G7JyzUe0EmkKsnfa5OVPXNkr1Qu 4lB02Q/gi1FCJZ0r8lal8SFguktHmeMCjoFdv21febOBceA2bNO1W25cNb3R9Ew/zHjI e7+xkVBGxXxS/kM1nASoSv99ltAKuAczLgUK6okNjnFwRaeksNLadwk7umne31lDafXa SeZ00b/5LvjS9+r74WeGuc+6qjBOtnY/d/KmQItHYaZ/3J4Zl8W2TOWCppbKmuiis/Jw iCgg== X-Gm-Message-State: AOAM533poMfvmilCEyNz3aOPm/IYwVORr/m82Mko9r+pUq65rlmqsnL2 nOvBsQqJ74dmv9KanAnkX8hfW0w14Ky4x7YKFQ0= X-Google-Smtp-Source: ABdhPJyphYZARxSQ3eZ20fkLrCwLnqSq8hbl+WU+W68ygugbIhgq/OB/aVIc3g6EHxNdGi5amR2+VitHd9pf6KFOWOM= Sender: "ndesaulniers via sendgmr" X-Received: from ndesaulniers1.mtv.corp.google.com ([2620:15c:211:202:f693:9fff:fef4:4d25]) (user=ndesaulniers job=sendgmr) by 2002:a25:2d5f:: with SMTP id s31mr9272103ybe.90.1610154073350; Fri, 08 Jan 2021 17:01:13 -0800 (PST) Date: Fri, 8 Jan 2021 17:01:11 -0800 In-Reply-To: <1610099389-28329-1-git-send-email-pnagar@codeaurora.org> Message-Id: <20210109010111.2299669-1-ndesaulniers@google.com> Mime-Version: 1.0 References: <1610099389-28329-1-git-send-email-pnagar@codeaurora.org> X-Mailer: git-send-email 2.30.0.284.gd98b1dd5eaa7-goog Subject: Re: [RFC PATCH v2] selinux: security: Move selinux_state to a separate page From: Nick Desaulniers To: pnagar@codeaurora.org Cc: arnd@arndb.de, dsule@codeaurora.org, eparis@parisplace.org, jmorris@namei.org, joe@perches.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, jeffv@google.com, nmardana@codeaurora.org, ojeda@kernel.org, paul@paul-moore.com, psodagud@codeaurora.org, selinux@vger.kernel.org, serge@hallyn.com, stephen.smalley.work@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Via: https://lore.kernel.org/lkml/1610099389-28329-1-git-send-email-pnagar@codeaurora.org/ > diff --git a/include/linux/init.h b/include/linux/init.h > index 7b53cb3..617adcf 100644 > --- a/include/linux/init.h > +++ b/include/linux/init.h > @@ -300,6 +300,10 @@ void __init parse_early_options(char *cmdline); > /* Data marked not to be saved by software suspend */ > #define __nosavedata __section(".data..nosave") > > +#ifdef CONFIG_SECURITY_RTIC > +#define __rticdata __section(".bss.rtic") if you put: #else #define __rticdata here, then you wouldn't need to label each datum you put in there. > +#endif > + > #ifdef MODULE > #define __exit_p(x) x > #else > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -104,7 +104,11 @@ > #include "audit.h" > #include "avc_ss.h" > > +#ifdef CONFIG_SECURITY_RTIC > +struct selinux_state selinux_state __rticdata; > +#else > struct selinux_state selinux_state; > +#endif so you could then drop the if-def here. Happy to see this resolved when building with LLD+LTO, which has been a problem in the past. Disabling selinux is a common attack vector on Android devices, so happy to see some effort towards mitigation. You might want to communicate the feature more to existing OEMs that are using your chipsets that support this feature.