From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB0C3C433DB for ; Tue, 12 Jan 2021 00:41:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83C06224BD for ; Tue, 12 Jan 2021 00:41:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391637AbhALAZM (ORCPT ); Mon, 11 Jan 2021 19:25:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:37198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404209AbhAKXwL (ORCPT ); Mon, 11 Jan 2021 18:52:11 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C583522BED; Mon, 11 Jan 2021 23:51:30 +0000 (UTC) Date: Mon, 11 Jan 2021 18:51:29 -0500 From: Steven Rostedt To: Qiujun Huang Cc: mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] trace: Remove get/put_cpu() from function_trace_init Message-ID: <20210111185129.0d5745f9@gandalf.local.home> In-Reply-To: <20201230140521.31920-1-hqjagain@gmail.com> References: <20201230140521.31920-1-hqjagain@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Dec 2020 22:05:21 +0800 Qiujun Huang wrote: > Since commit b6f11df26fdc ("trace: Call tracing_reset_online_cpus before > tracer->init()"), get/put_cpu() are not needed anymore. > We can use raw_smp_processor_id() instead. I added both your patches (this one and the trace_ignore_this_task() kernel-doc fix to my queue. Thanks! -- Steve > > Signed-off-by: Qiujun Huang > --- > v2: > Use raw_smp_processor_id() instead of smp_processor_id() > --- > kernel/trace/trace_functions.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/trace/trace_functions.c b/kernel/trace/trace_functions.c > index c5095dd28e20..f67aec5bb771 100644 > --- a/kernel/trace/trace_functions.c > +++ b/kernel/trace/trace_functions.c > @@ -106,8 +106,7 @@ static int function_trace_init(struct trace_array *tr) > > ftrace_init_array_ops(tr, func); > > - tr->array_buffer.cpu = get_cpu(); > - put_cpu(); > + tr->array_buffer.cpu = raw_smp_processor_id(); > > tracing_start_cmdline_record(); > tracing_start_function_trace(tr);