From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8289C433E0 for ; Mon, 11 Jan 2021 21:00:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9644C22D00 for ; Mon, 11 Jan 2021 21:00:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730766AbhAKVAI (ORCPT ); Mon, 11 Jan 2021 16:00:08 -0500 Received: from atlmailgw2.ami.com ([63.147.10.42]:64062 "EHLO atlmailgw2.ami.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728885AbhAKVAH (ORCPT ); Mon, 11 Jan 2021 16:00:07 -0500 X-AuditID: ac10606f-231ff70000001934-0b-5ffcbc2de2f4 Received: from atlms1.us.megatrends.com (atlms1.us.megatrends.com [172.16.96.144]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw2.ami.com (Symantec Messaging Gateway) with SMTP id 29.08.06452.D2CBCFF5; Mon, 11 Jan 2021 15:59:25 -0500 (EST) Received: from ami-us-wk.us.megatrends.com (172.16.98.207) by atlms1.us.megatrends.com (172.16.96.144) with Microsoft SMTP Server (TLS) id 14.3.468.0; Mon, 11 Jan 2021 15:59:24 -0500 From: Hongwei Zhang To: Dylan Hung , Joel Stanley , , , , Jakub Kicinski , David S Miller CC: Hongwei Zhang , netdev , Andrew Jeffery Subject: [Aspeed,ncsi-rx, v1 0/1] net: ftgmac100: Fix AST2600EVB NCSI RX issue Date: Mon, 11 Jan 2021 15:58:59 -0500 Message-ID: <20210111205900.22589-1-hongweiz@ami.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201215192323.24359-1-hongweiz@ami.com> References: <20201215192323.24359-1-hongweiz@ami.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.16.98.207] X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHLMWRmVeSWpSXmKPExsWyRiBhgq7unj/xBt0XTCx2XeawmHO+hcXi 67WNrBa/z/9ltriwrY/Vonn1OWaLy7vmsFkcWyBmcarlBYsDp8fV9l3sHl1377N7bFl5k8nj 4sdjzB6bVnWyeZyfsZDR4/MmuQD2KC6blNSczLLUIn27BK6MI68cClZIVqzauYitgfGHcBcj J4eEgInEoe4VbF2MXBxCAruYJPZsfMIC5TBKXHywgwWkik1ATWLv5jlMILaIwBdGidePgkBs ZoFMianHO9lBbGEBP4mTx46ydjFycLAIqEr0rikHCfMKmEp8ePGYGWKZvMTqDQeYQUo4Bcwk 9pySAwkLAZW07nvHBFEuKHFy5hMWiOkSEgdfvGCGqJGVuHXoMRPEGEWJB7++s05gFJiFpGUW kpYFjEyrGIUSS3JyEzNz0suN9BJzM/WS83M3MULCPH8H48eP5ocYmTgYDzFKcDArifB6bfgT L8SbklhZlVqUH19UmpNafIhRmoNFSZx3lfvReCGB9MSS1OzU1ILUIpgsEwenVAOjpx3X4gZO 24lXGp6oX14oXPbbfgW35X7vQyJ2dsvP3M4wvPqo7XX16v8/13/0O+pxbmnto9DErnu/X71d v1XlZJMU58abZj1cfzhVXsQsio595PT3gVNllNiPOVe81/D1yPW7mCQUF+5j3dJdxyzCMXPv hab9UuZV9WvcP773CGF9wvVcsdVHiaU4I9FQi7moOBEAUVm7GmECAAA= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Hi Hongwei, > > The NCSI should run on 3.3V RMII. According your log, you enabled NCSI on > ftgmac100@1e660000 which can only support 1.8V I/O voltage. > Did you observe the same error on ftgmac100@1e670000 (MAC3) or ftgmac100@1e690000 (MAC4)? > Hi Dylan, Thanks for your review and input, you're correct, this issue is not observed on AST2600 MAC4 (ftgmac100@1e690000). Though this issue is caused by using NCSI incompatible MAC ftgmac100@1e660000, we thought this patch is still having value, by providing an extra option to user to be able to use ftgmac100@1e660000 for NCSI, and this is also true for AST2500. --Hongwei > > -----Original Message----- > > From: Linux-aspeed > > [mailto:linux-aspeed-bounces+dylan_hung=aspeedtech.com@lists.ozlabs.or > > g] > > On Behalf Of Joel Stanley > > Sent: 2020?12?22? 10:26 AM > > To: Hongwei Zhang ; Ryan Chen > > > > Cc: linux-aspeed ; netdev > > ; OpenBMC Maillist ; > > Linux Kernel Mailing List ; Jakub > > Kicinski ; David S Miller > > Subject: Re: [Aspeed, ncsi-rx, v1 0/1] net: ftgmac100: Fix AST2600EVB > > NCSI RX issue > > > > On Mon, 21 Dec 2020 at 17:01, Hongwei Zhang wrote: > > > > > > Dear Reviewer, > > > > > > When FTGMAC100 driver is used on other NCSI Ethernet controllers, > > > few controllers have compatible issue. One example is Intel I210 > > > Ethernet controller on AST2600 BMC, with FTGMAC100 driver, it always > > > trigger RXDES0_RX_ERR error, cause NCSI initialization failure, > > > removing FTGMAC100_RXDES0_RX_ERR bit from RXDES0_ANY_ERROR fix the issue. > > > > I work with a few systems that use the i210 on the 2600. We haven't > > seen this issue in our testing. > > > > Is there something specific about the setup that you use to trigger this? > > > > Ryan, is this an issue that Aspeed is aware of? > > > > Cheers, > > > > Joel Hello Joel, Thanks for your review, please see my response to Dylan, he pointed out the root cause of the issue. -- Hongwei > > > > > > > > Here are part of the debug logs: > > > ...... > > > [ 35.075552] ftgmac100_hard_start_xmit TXDESO=b000003c > > > [ 35.080843] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 55 > > > [ 35.087141] ftgmac100 1e660000.ethernet eth0: rx_packet_error > > RXDES0=0xb0070040 > > > [ 37.067831] IPv6: ADDRCONF(NETDEV_UP): eth1: link is not ready > > > ............ > > > > > > This patch add a configurable flag, FTGMAC100_RXDES0_RX_ERR_CHK, in > > > FTGMAC100 driver, it is YES by default, so keep the orignal define > > > of RXDES0_ANY_ERROR. If it is needed, user can set the flag to NO to > > > remove the RXDES0_RX_ERR bit, to fix the issue. > > > > > > Hongwei Zhang (1): > > > net: ftgmac100: Fix AST2600 EVB NCSI RX issue > > > > > > drivers/net/ethernet/faraday/Kconfig | 9 +++++++++ > > > drivers/net/ethernet/faraday/ftgmac100.h | 8 ++++++++ > > > 2 files changed, 17 insertions(+) > > > > > > -- > > > 2.17.1 > > > >