From: "Roger Pau Monné" <roger.pau@citrix.com>
To: "Jürgen Groß" <jgross@suse.com>
Cc: <linux-kernel@vger.kernel.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Paul Durrant <paul.durrant@citrix.com>,
<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen/privcmd: allow fetching resource sizes
Date: Tue, 12 Jan 2021 11:03:24 +0100 [thread overview]
Message-ID: <20210112100324.ii34oqldfrtmfd2f@Air-de-Roger> (raw)
In-Reply-To: <5063e696-5a7f-4429-048e-2bf0d14881d7@suse.com>
On Tue, Jan 12, 2021 at 06:57:30AM +0100, Jürgen Groß wrote:
> On 11.01.21 16:29, Roger Pau Monne wrote:
> > Allow issuing an IOCTL_PRIVCMD_MMAP_RESOURCE ioctl with num = 0 and
> > addr = 0 in order to fetch the size of a specific resource.
> >
> > Add a shortcut to the default map resource path, since fetching the
> > size requires no address to be passed in, and thus no VMA to setup.
> >
> > Fixes: 3ad0876554caf ('xen/privcmd: add IOCTL_PRIVCMD_MMAP_RESOURCE')
>
> I don't think this addition is a reason to add a "Fixes:" tag. This is
> clearly new functionality.
It could be argued that not allowing to query the resource size was a
shortcoming of the original implementation, but a backport request to
stable would be more appropriate than a fixes tag I think. Will drop
on next version and add a backport request if you agree.
Thanks, Roger.
next prev parent reply other threads:[~2021-01-12 10:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 15:29 Roger Pau Monne
2021-01-11 22:09 ` boris.ostrovsky
2021-01-11 22:39 ` Andrew Cooper
2021-01-12 5:50 ` Jürgen Groß
2021-01-12 6:01 ` Jürgen Groß
2021-01-12 5:57 ` Jürgen Groß
2021-01-12 10:03 ` Roger Pau Monné [this message]
2021-01-12 10:34 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112100324.ii34oqldfrtmfd2f@Air-de-Roger \
--to=roger.pau@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®