mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daejun Park <daejun7.park@samsung.com>
To: Can Guo <cang@codeaurora.org>, Daejun Park <daejun7.park@samsung.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	"avri.altman@wdc.com" <avri.altman@wdc.com>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
	"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	"huobean@gmail.com" <huobean@gmail.com>,
	ALIM AKHTAR <alim.akhtar@samsung.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Sung-Jun Park <sungjun07.park@samsung.com>,
	yongmyung lee <ymhungry.lee@samsung.com>,
	Jinyoung CHOI <j-young.choi@samsung.com>,
	Adel Choi <adel.choi@samsung.com>,
	BoRam Shin <boram.shin@samsung.com>,
	SEUNGUK SHIN <seunguk.shin@samsung.com>
Subject: RE: Re: [PATCH v18 3/3] scsi: ufs: Prepare HPB read for cached sub-region
Date: Wed, 13 Jan 2021 10:36:33 +0900	[thread overview]
Message-ID: <20210113013633epcms2p60b9dccaa405ff568a18d28b94089665b@epcms2p6> (raw)
In-Reply-To: <e9b2479d0371e3cbe8aeb6c90ffb5d72@codeaurora.org>

Hi Can Guo,

> > +static void
> > +ufshpb_set_hpb_read_to_upiu(struct ufshpb_lu *hpb, struct ufshcd_lrb 
> > *lrbp,
> > +				  u32 lpn, u64 ppn,  unsigned int transfer_len)
> > +{
> > +	unsigned char *cdb = lrbp->ucd_req_ptr->sc.cdb;
> > +
> > +	cdb[0] = UFSHPB_READ;
> 
> You are only replacing opcode in cdb[0], but ufshcd_add_command_trace() 
> is
> counting on lrbp->cmd->cmnd. This will lead to wrong opcode recorded by 
> UFS ftrace.
> 
You're comment is good point for improving this patch. But there is no "case" for HPB read (0xF8) in ufshcd_add_command_trace().
So I will add codes to support tracing HPB read command in ufshcd_add_command_trace() on next patch.

Thanks,
Daejun

  parent reply	other threads:[~2021-01-13  1:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20201222015704epcms2p643f0c5011064a7ce56b08331811a8509@epcms2p6>
2020-12-22  1:57 ` [PATCH v18 0/3] scsi: ufs: Add Host Performance Booster Support Daejun Park
     [not found]   ` <CGME20201222015704epcms2p643f0c5011064a7ce56b08331811a8509@epcms2p5>
2020-12-22  1:58     ` [PATCH v18 2/3] scsi: ufs: L2P map management for HPB read Daejun Park
     [not found]   ` <CGME20201222015704epcms2p643f0c5011064a7ce56b08331811a8509@epcms2p1>
2020-12-22  1:58     ` [PATCH v18 3/3] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
2021-01-11  4:10       ` Can Guo
2020-12-22  1:57 ` [PATCH v18 1/3] scsi: ufs: Introduce HPB feature Daejun Park
2021-01-13  1:36 ` Daejun Park [this message]
2021-01-14  4:09   ` [PATCH v18 3/3] scsi: ufs: Prepare HPB read for cached sub-region Can Guo
2021-01-15  7:59 ` Daejun Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210113013633epcms2p60b9dccaa405ff568a18d28b94089665b@epcms2p6 \
    --to=daejun7.park@samsung.com \
    --cc=adel.choi@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avri.altman@wdc.com \
    --cc=boram.shin@samsung.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=huobean@gmail.com \
    --cc=j-young.choi@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=seunguk.shin@samsung.com \
    --cc=stanley.chu@mediatek.com \
    --cc=sungjun07.park@samsung.com \
    --cc=ymhungry.lee@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®