mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [PATCH 20/30] drm/amd/display/dc/core/dc: Fix a bunch of documentation misdemeanours
Date: Wed, 13 Jan 2021 08:07:42 +0000	[thread overview]
Message-ID: <20210113080752.1003793-21-lee.jones@linaro.org> (raw)
In-Reply-To: <20210113080752.1003793-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:287: warning: Cannot understand  *****************************************************************************
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:366: warning: Function parameter or member 'crc_window' not described in 'dc_stream_configure_crc'
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:430: warning: Function parameter or member 'r_cr' not described in 'dc_stream_get_crc'
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:430: warning: Function parameter or member 'g_y' not described in 'dc_stream_get_crc'
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:430: warning: Function parameter or member 'b_cb' not described in 'dc_stream_get_crc'
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2026: warning: Function parameter or member 'dc' not described in 'dc_check_update_surfaces_for_stream'
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2026: warning: Function parameter or member 'updates' not described in 'dc_check_update_surfaces_for_stream'
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2026: warning: Function parameter or member 'surface_count' not described in 'dc_check_update_surfaces_for_stream'
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2026: warning: Function parameter or member 'stream_update' not described in 'dc_check_update_surfaces_for_stream'
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2026: warning: Function parameter or member 'stream_status' not described in 'dc_check_update_surfaces_for_stream'
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2822: warning: Function parameter or member 'dc' not described in 'dc_interrupt_set'
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2822: warning: Function parameter or member 'src' not described in 'dc_interrupt_set'
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2822: warning: Function parameter or member 'enable' not described in 'dc_interrupt_set'
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2962: warning: Function parameter or member 'link' not described in 'dc_link_add_remote_sink'
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2962: warning: Function parameter or member 'edid' not described in 'dc_link_add_remote_sink'
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2962: warning: Function parameter or member 'len' not described in 'dc_link_add_remote_sink'
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2962: warning: Function parameter or member 'init_data' not described in 'dc_link_add_remote_sink'
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3022: warning: Function parameter or member 'link' not described in 'dc_link_remove_remote_sink'
 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3022: warning: Function parameter or member 'sink' not described in 'dc_link_remove_remote_sink'

Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/gpu/drm/amd/display/dc/core/dc.c | 33 ++++++++++++------------
 1 file changed, 16 insertions(+), 17 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index 0a07e608485ff..3ee3978fae977 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -284,20 +284,16 @@ static void dc_perf_trace_destroy(struct dc_perf_trace **perf_trace)
 }
 
 /**
- *****************************************************************************
- *  Function: dc_stream_adjust_vmin_vmax
+ *  dc_stream_adjust_vmin_vmax:
  *
- *  @brief
- *     Looks up the pipe context of dc_stream_state and updates the
- *     vertical_total_min and vertical_total_max of the DRR, Dynamic Refresh
- *     Rate, which is a power-saving feature that targets reducing panel
- *     refresh rate while the screen is static
+ *  Looks up the pipe context of dc_stream_state and updates the
+ *  vertical_total_min and vertical_total_max of the DRR, Dynamic Refresh
+ *  Rate, which is a power-saving feature that targets reducing panel
+ *  refresh rate while the screen is static
  *
- *  @param [in] dc: dc reference
- *  @param [in] stream: Initial dc stream state
- *  @param [in] adjust: Updated parameters for vertical_total_min and
- *  vertical_total_max
- *****************************************************************************
+ *  @dc:     dc reference
+ *  @stream: Initial dc stream state
+ *  @adjust: Updated parameters for vertical_total_min and vertical_total_max
  */
 bool dc_stream_adjust_vmin_vmax(struct dc *dc,
 		struct dc_stream_state *stream,
@@ -355,6 +351,7 @@ bool dc_stream_get_crtc_position(struct dc *dc,
  * @dc: DC Object
  * @stream: The stream to configure CRC on.
  * @enable: Enable CRC if true, disable otherwise.
+ * @crc_window: CRC window (x/y start/end) information
  * @continuous: Capture CRC on every frame if true. Otherwise, only capture
  *              once.
  *
@@ -420,7 +417,9 @@ bool dc_stream_configure_crc(struct dc *dc, struct dc_stream_state *stream,
  * dc_stream_get_crc() - Get CRC values for the given stream.
  * @dc: DC object
  * @stream: The DC stream state of the stream to get CRCs from.
- * @r_cr, g_y, b_cb: CRC values for the three channels are stored here.
+ * @r_cr: CRC value for the first of the 3 channels stored here.
+ * @g_y:  CRC value for the second of the 3 channels stored here.
+ * @b_cb: CRC value for the third of the 3 channels stored here.
  *
  * dc_stream_configure_crc needs to be called beforehand to enable CRCs.
  * Return false if stream is not found, or if CRCs are not enabled.
@@ -2012,7 +2011,7 @@ static enum surface_update_type check_update_surfaces_for_stream(
 	return overall_type;
 }
 
-/**
+/*
  * dc_check_update_surfaces_for_stream() - Determine update type (fast, med, or full)
  *
  * See :c:type:`enum surface_update_type <surface_update_type>` for explanation of update types
@@ -2815,7 +2814,7 @@ enum dc_irq_source dc_interrupt_to_irq_source(
 	return dal_irq_service_to_irq_source(dc->res_pool->irqs, src_id, ext_id);
 }
 
-/**
+/*
  * dc_interrupt_set() - Enable/disable an AMD hw interrupt source
  */
 bool dc_interrupt_set(struct dc *dc, enum dc_irq_source src, bool enable)
@@ -2949,7 +2948,7 @@ static bool link_add_remote_sink_helper(struct dc_link *dc_link, struct dc_sink
 	return true;
 }
 
-/**
+/*
  * dc_link_add_remote_sink() - Create a sink and attach it to an existing link
  *
  * EDID length is in bytes
@@ -3012,7 +3011,7 @@ struct dc_sink *dc_link_add_remote_sink(
 	return NULL;
 }
 
-/**
+/*
  * dc_link_remove_remote_sink() - Remove a remote sink from a dc_link
  *
  * Note that this just removes the struct dc_sink - it doesn't
-- 
2.25.1


  parent reply	other threads:[~2021-01-13  8:09 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13  8:07 [PATCH 00/30] [Set 13] Finally rid W=1 warnings from GPU Lee Jones
2021-01-13  8:07 ` [PATCH 01/30] drm/amd/display/dc/dc_helper: Include our own header, containing prototypes Lee Jones
2021-01-14 17:01   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 02/30] drm/amd/include/renoir_ip_offset: Mark top-level IP_BASE as __maybe_unused Lee Jones
2021-01-14 17:03   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 03/30] drm/amd/display/dmub/src/dmub_dcn30: Include our own header containing prototypes Lee Jones
2021-01-14 17:04   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 04/30] drm/amd/display/modules/power/power_helpers: Staticify local functions Lee Jones
2021-01-14 17:05   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 05/30] drm/amd/display/modules/info_packet/info_packet: Correct kernel-doc formatting Lee Jones
2021-01-14 17:06   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 06/30] drm/amd/display/dc/core/dc_resource: Staticify local functions Lee Jones
2021-01-14 17:07   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 07/30] drm/amd/display/dc/core/dc_link: Remove unused variable 'status' Lee Jones
2021-01-14 17:08   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 08/30] drm/amd/display/dc/core/dc_link_dp: Staticify local function 'linkRateInKHzToLinkRateMultiplier' Lee Jones
2021-01-14 17:09   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 09/30] drm/amd/display/dc/dce112/dce112_resource: Include our own header file containing prototypes Lee Jones
2021-01-14 17:10   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 10/30] drm/amd/display/dc/core/dc: Staticise local function 'apply_ctx_interdependent_lock' Lee Jones
2021-01-14 17:11   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 11/30] drm/amd/display/dc/dce100/Makefile: Ignore -Woverride-init warning Lee Jones
2021-01-14 17:11   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 12/30] drm/amd/display/dc/dce100/dce100_resource: Include our own header containing prototypes Lee Jones
2021-01-14 17:12   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 13/30] drm/amd/display/dc/dce60/Makefile: Ignore -Woverride-init warning Lee Jones
2021-01-14 17:13   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 14/30] drm/amd/display/dc/dce80/Makefile: " Lee Jones
2021-01-14 17:14   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 15/30] drm/amd/display/dc/dce80/dce80_resource: Include our own header containing prototypes Lee Jones
2021-01-14 17:14   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 16/30] fixup! drm/amd/display/dc/dce60/Makefile: Ignore -Woverride-init warning Lee Jones
2021-01-13  8:07 ` [PATCH 17/30] drm/amd/display/dc/dce60/dce60_resource: Include our own header containing prototypes Lee Jones
2021-01-14 17:15   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 18/30] drm/amd/display/dc/core/dc_link: Move some local data from the stack to the heap Lee Jones
2021-01-14 17:17   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 19/30] drm/amd/display/dc/core/dc_link_dp: Mark 'result_write_min_hblank' as __maybe_unused Lee Jones
2021-01-14 17:21   ` Alex Deucher
2021-01-13  8:07 ` Lee Jones [this message]
2021-01-14 17:22   ` [PATCH 20/30] drm/amd/display/dc/core/dc: Fix a bunch of documentation misdemeanours Alex Deucher
2021-01-13  8:07 ` [PATCH 21/30] drm/amd/display/dc/core/dc_resource: Demote some kernel-doc abuses Lee Jones
2021-01-14 17:22   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 22/30] drm/amd/display/dc/core/dc_link: Fix a couple of function documentation issues Lee Jones
2021-01-14 17:23   ` Alex Deucher
2021-01-13  8:07 ` [PATCH 23/30] drm/nouveau/nvkm/engine/gr/gf100: Demote non-conformant kernel-doc header Lee Jones
2021-01-13  8:07 ` [PATCH 24/30] drm/nouveau/nouveau_bo: Remove unused variables 'dev' Lee Jones
2021-01-13  8:07 ` [PATCH 25/30] drm/nouveau/nouveau_display: Remove set but unused variable 'width' Lee Jones
2021-01-13  8:07 ` [PATCH 26/30] drm/nouveau/dispnv04/crtc: Demote non-conforming kernel-doc headers Lee Jones
2021-01-13  8:07 ` [PATCH 27/30] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' from function returning void Lee Jones
2021-01-13  8:07 ` [PATCH 28/30] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static Lee Jones
2021-01-13 18:48   ` Lyude Paul
2021-01-13  8:07 ` [PATCH 29/30] drm/nouveau/nv50_display: Remove superfluous prototype for local static functions Lee Jones
2021-01-13  8:07 ` [PATCH 30/30] drm/nouveau/dispnv50/disp: Include header containing our prototypes Lee Jones
2021-01-14 10:33 ` [PATCH 00/30] [Set 13] Finally rid W=1 warnings from GPU Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210113080752.1003793-21-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®