Re: [PATCH] mm/compaction: return proper state in should_proactive_compact_node

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 13 Jan 2021 19:33:06 +0530 Charan Teja Reddy <charante@codeaurora.org> wrote:

> should_proactive_compact_node() returns true when sum of the
> fragmentation score of all the zones in the node is greater than the
> wmark_high of compaction which then triggers the proactive compaction
> that operates on the individual zones of the node. But proactive
> compaction runs on the zone only when the fragmentation score of the
> zone is greater than wmark_low(=wmark_high - 10).
> 
> This means that the sum of the fragmentation scores of all the zones can
> exceed the wmark_high but individual zone scores can still be less than
> the wmark_low which makes the unnecessary trigger of the proactive
> compaction only to return doing nothing.
> 
> Another issue with the return of proactive compaction with out even
> trying is its deferral. It is simply deferred for 1 <<
> COMPACT_MAX_DEFER_SHIFT if the scores across the proactive compaction is
> same, thinking that compaction didn't make any progress but in reality
> it didn't even try. With the delay between successive retries for
> proactive compaction is 500msec, it can result into the deferral for
> ~30sec with out even trying the proactive compaction.
> 
> Test scenario is that: compaction_proactiveness=50 thus the wmark_low =
> 50 and wmark_high = 60. System have 2 zones(Normal and Movable) with
> sizes 5GB and 6GB respectively. After opening some apps on the android,
> the fragmentation scores of these zones are 47 and 49 respectively.
> Since the sum of these fragmentation scores are above the wmark_high
> which triggers the proactive compaction and there since the individual
> zone scores are below wmark_low, it returns without trying the
> compaction. As a result the fragmentation scores of the zones are still
> 47 and 49 which makes the existing logic to defer the compaction
> thinking that noprogress is made across the compaction.
> 
> So, run the proactive compaction on the node zones only when atleast one
> of the zones fragmentation score is greater than wmark_low. This avoids
> the unnecessary deferral and retries of the compaction.
> 
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1964,6 +1964,26 @@ static unsigned int fragmentation_score_node(pg_data_t *pgdat)
>  	return score;
>  }
>  
> +/*
> + * Returns the maximum of fragmentation scores of zones in a node. This is
> + * used in taking the decission of whether to trigger the proactive compaction
> + * on the zones of this node.
> + */
> +static unsigned int fragmentation_score_node_zones_max(pg_data_t *pgdat)
> +{
> +	int zoneid;
> +	unsigned int max = 0;
> +
> +	for (zoneid = 0; zoneid < MAX_NR_ZONES; zoneid++) {
> +		struct zone *zone;
> +
> +		zone = &pgdat->node_zones[zoneid];
> +		max = max_t(unsigned int, fragmentation_score_zone(zone), max);

Both args are unsigned int, so I think the max_t is unnecessary?

--- a/mm/compaction.c~mm-compaction-return-proper-state-in-should_proactive_compact_node-fix
+++ a/mm/compaction.c
@@ -1975,7 +1975,7 @@ static unsigned int fragmentation_score_
 		struct zone *zone;
 
 		zone = &pgdat->node_zones[zoneid];
-		max = max_t(unsigned int, fragmentation_score_zone(zone), max);
+		max = max(fragmentation_score_zone(zone), max);
 	}
 
 	return max;
_