From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 549F1C433E6 for ; Fri, 15 Jan 2021 03:45:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D23F23772 for ; Fri, 15 Jan 2021 03:45:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732683AbhAODox (ORCPT ); Thu, 14 Jan 2021 22:44:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732584AbhAODow (ORCPT ); Thu, 14 Jan 2021 22:44:52 -0500 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A71DC061794 for ; Thu, 14 Jan 2021 19:43:35 -0800 (PST) Received: by mail-pl1-x635.google.com with SMTP id s15so4005219plr.9 for ; Thu, 14 Jan 2021 19:43:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=N02fXbKOI7v6bUS+6ErTrlEXeCZ9jXtdBRasx3q08w0=; b=mKunPSwe5cY8Jq+pZp/q/jWVNLm6J/94C7SlgZ1saNZD+u179Yg5eJLEWVwdN9ac6T 3UmexIt33g2zin8AqRYNL7+wPKLVZ2mGBcaI3VL4hswRnnaw6f5zEbVTAnUJ93GwBA6q jKW2LWlcA+zSMTCRInUKsnLh/PSkLcstavtt0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N02fXbKOI7v6bUS+6ErTrlEXeCZ9jXtdBRasx3q08w0=; b=gC7UbVXiKY3VMyaycyj3Ka0zY6GowzbtGkSyAbU/YOkAcQ9LBIrdYUeOWwN58nRgX+ o+GVEyy5sttVu8u8eDEbvLaunp/EGQTGc15+G1527yG3qG/M3viQrFF2br218RRw14uX IbeuuAj+KItFbqsqjXeFQjh021myhRTYfFOA/4up7LVXq6fBgPPpbb09a6ZB0zy6gJ8m 11iIvNqEDj8Jajlh1NYAfM8arJetFFH9d2x9TkF9Tew/WT/y2zqRY7whLvx2+xr5WnCE HpK7G9rKXITi5ttUefc2uO3y2VQW9j4BvvavdIb5b22oLYDVCuHJxsEMgZ3TKVbzs4ex 6VTQ== X-Gm-Message-State: AOAM532B+euTWtSY2WowEDX1f5HRgCb2uundzOvXH/tUEDFjg2lHocOi h9YFfD4yTHcm6K7lU2Wm1qHUgQ== X-Google-Smtp-Source: ABdhPJwONZ49KttbKspvQKQ84ZbdgIuIs4XUSlLwyr+p6TbSHNrMDViOQjMd8t54JjJoO3hLbKGLWw== X-Received: by 2002:a17:90a:bb8c:: with SMTP id v12mr8330161pjr.227.1610682214983; Thu, 14 Jan 2021 19:43:34 -0800 (PST) Received: from smtp.gmail.com ([2620:15c:202:201:3e52:82ff:fe6c:83ab]) by smtp.gmail.com with ESMTPSA id u12sm6499062pfh.98.2021.01.14.19.43.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 19:43:34 -0800 (PST) From: Stephen Boyd To: Mark Brown Cc: linux-kernel@vger.kernel.org, Liam Girdwood , Banajit Goswami , linux-arm-msm@vger.kernel.org, Patrick Lai , alsa-devel@alsa-project.org, V Sujith Kumar Reddy , Srinivasa Rao , Srinivas Kandagatla , Cheng-Yi Chiang Subject: [PATCH 4/4] ASoC: qcom: Remove duplicate error messages on ioremap Date: Thu, 14 Jan 2021 19:43:27 -0800 Message-Id: <20210115034327.617223-5-swboyd@chromium.org> X-Mailer: git-send-email 2.30.0.284.gd98b1dd5eaa7-goog In-Reply-To: <20210115034327.617223-1-swboyd@chromium.org> References: <20210115034327.617223-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We don't need to print an error message when these ioremap operations fail. The function that returns an error already prints an error message and properly attributes it to the device. Drop them to save some code. Cc: V Sujith Kumar Reddy Cc: Srinivasa Rao Cc: Srinivas Kandagatla Cc: Cheng-Yi Chiang Signed-off-by: Stephen Boyd --- sound/soc/qcom/lpass-cpu.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index b267fe8db3fc..0ca957dcd3fe 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b/sound/soc/qcom/lpass-cpu.c @@ -788,11 +788,8 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev) res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-lpaif"); drvdata->lpaif = devm_ioremap_resource(dev, res); - if (IS_ERR(drvdata->lpaif)) { - dev_err(dev, "error mapping reg resource: %ld\n", - PTR_ERR(drvdata->lpaif)); + if (IS_ERR(drvdata->lpaif)) return PTR_ERR(drvdata->lpaif); - } lpass_cpu_regmap_config.max_register = LPAIF_WRDMAPER_REG(variant, variant->wrdma_channels + @@ -810,11 +807,8 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev) res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-hdmiif"); drvdata->hdmiif = devm_ioremap_resource(dev, res); - if (IS_ERR(drvdata->hdmiif)) { - dev_err(dev, "error mapping reg resource: %ld\n", - PTR_ERR(drvdata->hdmiif)); + if (IS_ERR(drvdata->hdmiif)) return PTR_ERR(drvdata->hdmiif); - } lpass_hdmi_regmap_config.max_register = LPAIF_HDMI_RDMAPER_REG(variant, variant->hdmi_rdma_channels); -- https://chromeos.dev