From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Daniel Scally <djrscally@gmail.com>,
gregkh@linuxfoundation.org, rafael@kernel.org,
linux-kernel@vger.kernel.org, heikki.krogerus@linux.intel.com
Subject: Re: [PATCH v2] software_node: Add kernel-doc comments to exported symbols
Date: Mon, 18 Jan 2021 12:33:55 +0200 [thread overview]
Message-ID: <20210118103355.GZ4077@smile.fi.intel.com> (raw)
In-Reply-To: <20210118094945.GX11878@paasikivi.fi.intel.com>
On Mon, Jan 18, 2021 at 11:49:46AM +0200, Sakari Ailus wrote:
> On Wed, Jan 13, 2021 at 12:02:09AM +0000, Daniel Scally wrote:
> > + * to_software_node() - Fetch software node associated with a firmware node handle
>
> Please wrap lines over 80 (unless there's a reason to keep them longer).
Does kernel-doc behave good when you wrap the function summary line?
My impression that summary should be one line.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-01-18 20:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 0:02 Daniel Scally
2021-01-13 1:01 ` Randy Dunlap
2021-01-14 8:29 ` Daniel Scally
2021-01-18 9:49 ` Sakari Ailus
2021-01-18 10:33 ` Andy Shevchenko [this message]
2021-01-18 10:35 ` Daniel Scally
2021-01-18 10:36 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118103355.GZ4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome