From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3AABC433DB for ; Mon, 18 Jan 2021 14:59:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67DE722C7E for ; Mon, 18 Jan 2021 14:59:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393098AbhARO7G (ORCPT ); Mon, 18 Jan 2021 09:59:06 -0500 Received: from elvis.franken.de ([193.175.24.41]:33798 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393026AbhARO6w (ORCPT ); Mon, 18 Jan 2021 09:58:52 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1l1Vyq-0008VQ-00; Mon, 18 Jan 2021 15:58:08 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 402D5C06E1; Mon, 18 Jan 2021 15:40:50 +0100 (CET) Date: Mon, 18 Jan 2021 15:40:50 +0100 From: Thomas Bogendoerfer To: Nathan Chancellor Cc: Nick Desaulniers , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, stable@vger.kernel.org, Anders Roxell Subject: Re: [PATCH] MIPS: VDSO: Use CLANG_FLAGS instead of filtering out '--target=' Message-ID: <20210118144050.GA11749@alpha.franken.de> References: <20210115192622.3828545-1-natechancellor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210115192622.3828545-1-natechancellor@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 15, 2021 at 12:26:22PM -0700, Nathan Chancellor wrote: > Commit ee67855ecd9d ("MIPS: vdso: Allow clang's --target flag in VDSO > cflags") allowed the '--target=' flag from the main Makefile to filter > through to the vDSO. However, it did not bring any of the other clang > specific flags for controlling the integrated assembler and the GNU > tools locations (--prefix=, --gcc-toolchain=, and -no-integrated-as). > Without these, we will get a warning (visible with tinyconfig): > > arch/mips/vdso/elf.S:14:1: warning: DWARF2 only supports one section per > compilation unit > .pushsection .note.Linux, "a",@note ; .balign 4 ; .long 2f - 1f ; .long > 4484f - 3f ; .long 0 ; 1:.asciz "Linux" ; 2:.balign 4 ; 3: > ^ > arch/mips/vdso/elf.S:34:2: warning: DWARF2 only supports one section per > compilation unit > .section .mips_abiflags, "a" > ^ > > All of these flags are bundled up under CLANG_FLAGS in the main Makefile > and exported so that they can be added to Makefiles that set their own > CFLAGS. Use this value instead of filtering out '--target=' so there is > no warning and all of the tools are properly used. > > Cc: stable@vger.kernel.org > Fixes: ee67855ecd9d ("MIPS: vdso: Allow clang's --target flag in VDSO cflags") > Link: https://github.com/ClangBuiltLinux/linux/issues/1256 > Reported-by: Anders Roxell > Signed-off-by: Nathan Chancellor > --- > arch/mips/vdso/Makefile | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]