From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Jinyang He <hejinyang@loongson.cn>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Burton <paulburton@kernel.org>,
Jun-Ru Chang <jrjang@realtek.com>
Subject: Re: [PATCH 1/4] MIPS: process: Reorder header files
Date: Mon, 18 Jan 2021 23:11:37 +0100 [thread overview]
Message-ID: <20210118221137.GA5818@alpha.franken.de> (raw)
In-Reply-To: <78c9211d-5304-a2b6-3a94-df9b324b7046@loongson.cn>
On Mon, Jan 18, 2021 at 06:02:08PM +0800, Jinyang He wrote:
> On 01/15/2021 10:46 PM, Thomas Bogendoerfer wrote:
>
> > On Tue, Jan 12, 2021 at 08:29:14PM +0800, Jinyang He wrote:
> > > Just reorder the header files.
> > This alone isn't worth a commit, IMHO. I bet there are lots of includes
> > no longer needed, so removing and sorting them is ok for me.
> >
> > Thomas.
> >
>
> Hi, Thomas,
>
> Thanks for your advice. I analyzed majority of the symbols in this file.
> The following are examples of header file references:
>
> Space indicates that it cannot be found. (Maybe I missed it.)
>
> Header files Examples in this file
> #include <linux/completion.h>
> * #include <linux/cpu.h> get_online_cpus
> * #include <linux/errno.h> EOPNOTSUPP
> [..]
thank you for doing this.
> By including only these header files which marked by '*', I have been able
> to compile and use certain functions (unwind_stack) normally. So are other
> header files no longer needed?
>
> In addition, <linux/cpu.h> includes <linux/cpumask.h>, and <linux/cpumask.h>
> includes <linux/kernel.h>. What should we do?
send a patch, which deletes the not needed #includes ;-)
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2021-01-18 22:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 12:29 [PATCH 0/4] MIPS: process: Some fixes and improvements about get_frame_info() Jinyang He
2021-01-12 12:29 ` [PATCH 1/4] MIPS: process: Reorder header files Jinyang He
2021-01-13 0:27 ` Huacai Chen
2021-01-15 14:46 ` Thomas Bogendoerfer
2021-01-18 10:02 ` Jinyang He
2021-01-18 11:27 ` Jinyang He
2021-01-18 22:11 ` Thomas Bogendoerfer [this message]
2021-01-12 12:29 ` [PATCH 2/4] MIPS: microMIPS: Fix the judgment of mm_jr16_op and mm_jalr_op Jinyang He
2021-01-12 12:29 ` [PATCH 3/4] MIPS: Fix get_frame_info() handing of function size Jinyang He
2021-01-12 12:29 ` [PATCH 4/4] MIPS: Add is_jr_ra_ins() to end the loop early Jinyang He
2021-10-23 18:32 ` Maciej W. Rozycki
2021-10-25 2:11 ` Jinyang He
2021-01-18 1:51 ` [PATCH 0/4] MIPS: process: Some fixes and improvements about get_frame_info() Jiaxun Yang
2021-01-19 1:29 ` Jinyang He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118221137.GA5818@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=hejinyang@loongson.cn \
--cc=jrjang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paulburton@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®