From: Emmanuel Vadot <manu@bidouilliste.com>
To: Drew Fustini <drew@beagleboard.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] pinctrl: clarify #pinctrl-cells for pinctrl-single,pins
Date: Wed, 20 Jan 2021 09:01:08 +0100 [thread overview]
Message-ID: <20210120090108.bbdee781a237cb931a572323@bidouilliste.com> (raw)
In-Reply-To: <20210120050342.320704-1-drew@beagleboard.org>
On Tue, 19 Jan 2021 21:03:44 -0800
Drew Fustini <drew@beagleboard.org> wrote:
> Document that #pinctrl-cells can be 1 or 2 for pinctrl-single,pins
>
> Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2")
> Reported-by: Emmanuel Vadot <manu@bidouilliste.com>
> Link: https://lore.kernel.org/linux-gpio/20210115190201.9273b637a7f967e7e55bc740@bidouilliste.com/
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
> index f903eb4471f8..bb9999119314 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
> @@ -8,7 +8,7 @@ Required properties:
> - reg : offset and length of the register set for the mux registers
>
> - #pinctrl-cells : number of cells in addition to the index, set to 1
> - for pinctrl-single,pins and 2 for pinctrl-single,bits
> + or 2 for pinctrl-single,pins and set to 2 for pinctrl-single,bits
>
> - pinctrl-single,register-width : pinmux register access width in bits
>
> --
> 2.25.1
>
Reviewed-by: Emmanuel Vadot <manu@FreeBSD.org>
Thanks, now the docs make more sense :)
--
Emmanuel Vadot <manu@bidouilliste.com> <manu@FreeBSD.org>
next prev parent reply other threads:[~2021-01-20 8:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 5:03 Drew Fustini
2021-01-20 8:01 ` Emmanuel Vadot [this message]
2021-01-21 7:06 ` Tony Lindgren
2021-01-22 13:20 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120090108.bbdee781a237cb931a572323@bidouilliste.com \
--to=manu@bidouilliste.com \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®