mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Cc: pkshih@realtek.com, kvalo@codeaurora.org, davem@davemloft.net,
	kuba@kernel.org, colin.king@canonical.com,
	Larry.Finger@lwfinger.net, andriy.shevchenko@linux.intel.com,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: Assign boolean values to a bool variable
Date: Wed, 20 Jan 2021 10:08:33 +0100	[thread overview]
Message-ID: <20210120090833.loukh7x72dk5jhox@linutronix.de> (raw)
In-Reply-To: <1611127628-50504-1-git-send-email-abaci-bugfix@linux.alibaba.com>

On 2021-01-20 15:27:08 [+0800], Jiapeng Zhong wrote:
> diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> index be4c0e6..c198222 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> @@ -873,7 +873,7 @@ static void halbtc_display_wifi_status(struct btc_coexist *btcoexist,
>  	dc_mode = true;	/*TODO*/
>  	under_ips = rtlpriv->psc.inactive_pwrstate == ERFOFF ? 1 : 0;
>  	under_lps = rtlpriv->psc.dot11_psmode == EACTIVE ? 0 : 1;
> -	low_power = 0; /*TODO*/
> +	low_power = false; /*TODO*/

you could drop that assignment as it is already initialized to false at
the top.

>  	seq_printf(m, "\n %-35s = %s%s%s%s",
>  		   "Power Status",
>  		   (dc_mode ? "DC mode" : "AC mode"),

Sebastian

      reply	other threads:[~2021-01-20  9:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  7:27 Jiapeng Zhong
2021-01-20  9:08 ` Sebastian Andrzej Siewior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210120090833.loukh7x72dk5jhox@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=Larry.Finger@lwfinger.net \
    --cc=abaci-bugfix@linux.alibaba.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=colin.king@canonical.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®