From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4775EC433E6 for ; Wed, 20 Jan 2021 11:51:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFB6023331 for ; Wed, 20 Jan 2021 11:51:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731424AbhATLiS (ORCPT ); Wed, 20 Jan 2021 06:38:18 -0500 Received: from mga18.intel.com ([134.134.136.126]:50461 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733261AbhATKi7 (ORCPT ); Wed, 20 Jan 2021 05:38:59 -0500 IronPort-SDR: IdyA32rCVCDh9U+fbyV2ii6Wqnpm/WC4sTSEejRzrh21NZx+z810gy7M81xtDrnugtI/wMevqV wVT0248MbKhg== X-IronPort-AV: E=McAfee;i="6000,8403,9869"; a="166745658" X-IronPort-AV: E=Sophos;i="5.79,360,1602572400"; d="scan'208";a="166745658" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 02:36:53 -0800 IronPort-SDR: ea0/FmMHB3StJdYQIaQoBimu5XQcLNU9YeInwP5wV7gJbK85SSO9l65dJ9TsYzobrMoP3u+5R/ 4i7vUyRJzxBA== X-IronPort-AV: E=Sophos;i="5.79,360,1602572400"; d="scan'208";a="347507163" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 02:36:50 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id CBE6F20503; Wed, 20 Jan 2021 12:36:48 +0200 (EET) Date: Wed, 20 Jan 2021 12:36:48 +0200 From: Sakari Ailus To: Kieran Bingham Cc: Lad Prabhakar , Mauro Carvalho Chehab , Laurent Pinchart , Jacopo Mondi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das , Prabhakar Subject: Re: [PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor Message-ID: <20210120103648.GI11878@paasikivi.fi.intel.com> References: <20210120090148.30598-1-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2021 at 10:17:14AM +0000, Kieran Bingham wrote: > Hi Lad, > > On 20/01/2021 09:01, Lad Prabhakar wrote: > > Fix OV772x build breakage by selecting V4L2_FWNODE config: > > > > ia64-linux-ld: drivers/media/i2c/ov772x.o: in function `ov772x_probe': > > ov772x.c:(.text+0x1ee2): undefined reference to `v4l2_fwnode_endpoint_alloc_parse' > > ia64-linux-ld: ov772x.c:(.text+0x1f12): undefined reference to `v4l2_fwnode_endpoint_free' > > ia64-linux-ld: ov772x.c:(.text+0x2212): undefined reference to `v4l2_fwnode_endpoint_alloc_parse' > > > > Fixes: 8a10b4e3601e ("media: i2c: ov772x: Parse endpoint properties") > > Reported-by: kernel test robot > > Signed-off-by: Lad Prabhakar > > I see this driver uses subdev API too. > > Should the driver also select VIDEO_V4L2_SUBDEV_API? Yes, it should. Another patch? This one fixes a compilation problem. > > Or is that covered sufficiently already on any platforms that would use > the driver? > > Reviewed-by: Kieran Bingham > > > --- > > drivers/media/i2c/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > index eddb10220953..bb1b5a340431 100644 > > --- a/drivers/media/i2c/Kconfig > > +++ b/drivers/media/i2c/Kconfig > > @@ -1013,6 +1013,7 @@ config VIDEO_OV772X > > tristate "OmniVision OV772x sensor support" > > depends on I2C && VIDEO_V4L2 > > select REGMAP_SCCB > > + select V4L2_FWNODE > > help > > This is a Video4Linux2 sensor driver for the OmniVision > > OV772x camera. > > > -- Sakari Ailus