mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Kyle Tso <kyletso@google.com>,
	linux@roeck-us.net, badhri@google.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/3] AMS, Collision Avoidance, and Protocol Error
Date: Thu, 21 Jan 2021 09:30:30 +0200	[thread overview]
Message-ID: <20210121073030.GA423216@kuha.fi.intel.com> (raw)
In-Reply-To: <YAhlrxRdURu0djbf@kroah.com>

On Wed, Jan 20, 2021 at 06:17:35PM +0100, Greg KH wrote:
> On Wed, Jan 20, 2021 at 02:45:02PM +0100, Hans de Goede wrote:
> > Hi,
> > 
> > On 1/14/21 3:50 PM, Kyle Tso wrote:
> > > v5 https://lore.kernel.org/r/20210105163927.1376770-1-kyletso@google.com
> > > 
> > > "usb: typec: tcpm: AMS and Collision Avoidance"
> > >  - removed the signed-off
> > >  - modified the coding style suggested from Heikki
> > >  - added FR_SWAP AMS handling
> > > 
> > > "usb: typec: tcpm: Protocol Error handling"
> > >  - removed the signed-off
> > >  - modified the coding style suggested from Heikki
> > >  - modified more coding style problems (line wrapping limit)
> > > 
> > > "usb: typec: tcpm: Respond Wait if VDM state machine is running"
> > >  - no change
> > 
> > I've finally gotten around to testing this. I'm happy to
> > report that the power-role swapping regression seen in one
> > of the older versions of this patch-set is gone.
> > 
> > So the entire series is:
> > Tested-by: Hans de Goede <hdegoede@redhat.com>
> 
> Thanks for testing and the review.
> 
> Heikki, any thoughts?

Looks good to me.

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

-- 
heikki

  reply	other threads:[~2021-01-21  7:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 14:50 Kyle Tso
2021-01-14 14:50 ` [PATCH v6 1/3] usb: typec: tcpm: AMS and Collision Avoidance Kyle Tso
2021-01-14 14:50 ` [PATCH v6 2/3] usb: typec: tcpm: Protocol Error handling Kyle Tso
2021-01-14 14:50 ` [PATCH v6 3/3] usb: typec: tcpm: Respond Wait if VDM state machine is running Kyle Tso
2021-01-15 10:40 ` [PATCH v6 0/3] AMS, Collision Avoidance, and Protocol Error Hans de Goede
2021-01-20 13:45 ` Hans de Goede
2021-01-20 17:17   ` Greg KH
2021-01-21  7:30     ` Heikki Krogerus [this message]
2021-01-23 19:59 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210121073030.GA423216@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=badhri@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=kyletso@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome