From: Vincent Donnefort <vincent.donnefort@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
valentin.schneider@arm.com
Subject: Re: [PATCH 4/4] cpu/hotplug: Fix CPU down rollback
Date: Thu, 21 Jan 2021 15:43:15 +0000 [thread overview]
Message-ID: <20210121154314.GA439562@e120877-lin.cambridge.arm.com> (raw)
In-Reply-To: <YAmWP1vbLYFgl82n@hirez.programming.kicks-ass.net>
On Thu, Jan 21, 2021 at 03:57:03PM +0100, Peter Zijlstra wrote:
> On Mon, Jan 11, 2021 at 05:10:47PM +0000, vincent.donnefort@arm.com wrote:
> > From: Vincent Donnefort <vincent.donnefort@arm.com>
> >
> > After the AP brought itself down to CPUHP_TEARDOWN_CPU, the BP will finish
> > the job. The steps left are as followed:
> >
> > +--------------------+
> > | CPUHP_TEARDOWN_CPU | -> If fails state is CPUHP_TEARDOWN_CPU
> > +--------------------+
> > | ATOMIC STATES | -> Cannot Fail
> > +--------------------+
> > | CPUHP_BRINGUP_CPU | -> Cannot fail
> > +--------------------+
> > | ... |
> > | ... | -> Can fail and rollback
>
> These are the PREPARE/DEAD states, right? It would be _really_ daft for
> a DEAD notifier to fail. But yeah, I suppose that if it does, it will
> indeed end up in CPUHP_AP_ONLINE_IDLE.
>
> Do we want to WARN when a DEAD notifier fails?
>
>
Indeed, I couldn't find a dead callback which can return an error. So I
suppose we could go for another strategy here, that would be to not allow
failure for the dead states (i.e states < BRINGUP_CPU when hotunplug). In
that case, the fail interface should probably disallow selecting those
states and a WARN here would be good.
--
Vincent
prev parent reply other threads:[~2021-01-21 16:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 17:10 [PATCH 0/4] cpu/hotplug: rollback and "fail" interface fixes vincent.donnefort
2021-01-11 17:10 ` [PATCH 1/4] cpu/hotplug: Allowing to reset fail injection vincent.donnefort
2021-01-11 17:10 ` [PATCH 2/4] cpu/hotplug: CPUHP_BRINGUP_CPU exception in " vincent.donnefort
2021-01-20 12:58 ` Peter Zijlstra
2021-01-20 15:17 ` Vincent Donnefort
2021-01-20 17:30 ` Peter Zijlstra
2021-01-11 17:10 ` [PATCH 3/4] cpu/hotplug: Add cpuhp_invoke_callback_range() vincent.donnefort
2021-01-20 13:11 ` Peter Zijlstra
2021-01-20 17:54 ` Peter Zijlstra
2021-01-20 17:45 ` Peter Zijlstra
2021-01-20 17:53 ` Peter Zijlstra
2021-01-21 10:57 ` Vincent Donnefort
2021-01-21 11:18 ` Peter Zijlstra
2021-01-20 17:49 ` Peter Zijlstra
2021-01-11 17:10 ` [PATCH 4/4] cpu/hotplug: Fix CPU down rollback vincent.donnefort
2021-01-21 14:57 ` Peter Zijlstra
2021-01-21 15:43 ` Vincent Donnefort [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121154314.GA439562@e120877-lin.cambridge.arm.com \
--to=vincent.donnefort@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®