From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAEF7C433E6 for ; Sun, 24 Jan 2021 19:03:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7679C22D50 for ; Sun, 24 Jan 2021 19:03:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726640AbhAXTCn (ORCPT ); Sun, 24 Jan 2021 14:02:43 -0500 Received: from elvis.franken.de ([193.175.24.41]:36786 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726540AbhAXTCf (ORCPT ); Sun, 24 Jan 2021 14:02:35 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1l3kdz-0001qW-01; Sun, 24 Jan 2021 20:01:51 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 3180FC0C0E; Fri, 22 Jan 2021 14:06:09 +0100 (CET) Date: Fri, 22 Jan 2021 14:06:09 +0100 From: Thomas Bogendoerfer To: Arnd Bergmann Cc: Arnd Bergmann , kernel test robot , Jiaxun Yang , Paul Cercueil , Paul Burton , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] MIPS: make kgdb depend on FPU support Message-ID: <20210122130608.GB10580@alpha.franken.de> References: <20210122110307.934543-1-arnd@kernel.org> <20210122110307.934543-2-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210122110307.934543-2-arnd@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2021 at 12:02:51PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > kgdb fails to build when the FPU support is disabled: > > arch/mips/kernel/kgdb.c: In function 'dbg_set_reg': > arch/mips/kernel/kgdb.c:147:35: error: 'struct thread_struct' has no member named 'fpu' > 147 | memcpy((void *)¤t->thread.fpu.fcr31, mem, > | ^ > arch/mips/kernel/kgdb.c:155:34: error: 'struct thread_struct' has no member named 'fpu' > 155 | memcpy((void *)¤t->thread.fpu.fpr[fp_reg], mem, > > This is only relevant for CONFIG_EXPERT=y, so disallowing it > in Kconfig is an easier workaround than fixing it properly. > > Reported-by: kernel test robot > Signed-off-by: Arnd Bergmann > --- > arch/mips/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]