From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2406FC433E0 for ; Fri, 22 Jan 2021 18:16:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DAA7523A6A for ; Fri, 22 Jan 2021 18:16:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728950AbhAVSQL (ORCPT ); Fri, 22 Jan 2021 13:16:11 -0500 Received: from mx2.suse.de ([195.135.220.15]:33600 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730042AbhAVRzu (ORCPT ); Fri, 22 Jan 2021 12:55:50 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0631FAC6E; Fri, 22 Jan 2021 17:55:09 +0000 (UTC) Date: Fri, 22 Jan 2021 18:55:08 +0100 From: Daniel Wagner To: Christoph Hellwig Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Keith Busch , Jens Axboe , Sagi Grimberg Subject: Re: [PATCH] nvme-multipath: Early exit if no path is available Message-ID: <20210122175508.eiimz2fbx3csrejk@beryllium.lan> References: <20210122174125.145734-1-dwagner@suse.de> <20210122175029.GA21127@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210122175029.GA21127@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2021 at 06:50:29PM +0100, Christoph Hellwig wrote: > How can that happen once we're in the loop? As far I can tell, it's the first nvme_next_ns() call which returns the NULL pointer and this will pass the test 'ns != old'.