From: Stephen Boyd <swboyd@chromium.org>
To: Rob Herring <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>, Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-hwmon@vger.kernel.org
Subject: [PATCH v2 5/6] hwmon: (lm70) Avoid undefined reference to match table
Date: Fri, 22 Jan 2021 19:44:27 -0800 [thread overview]
Message-ID: <20210123034428.2841052-6-swboyd@chromium.org> (raw)
In-Reply-To: <20210123034428.2841052-1-swboyd@chromium.org>
We're going to remove of_match_ptr() from the definition of
of_match_device() when CONFIG_OF=n. This way we can always be certain
that of_match_device() acts the same when CONFIG_OF is set and when it
isn't. Add of_match_ptr() here so that this doesn't break when that
change is made to the of_match_device() API.
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Acked-by: Guenter Roeck <linux@roeck-us.net>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jean Delvare <jdelvare@suse.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>
Cc: <linux-hwmon@vger.kernel.org>
---
Please ack so Rob can apply.
drivers/hwmon/lm70.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c
index ae2b84263a44..e3153ae80634 100644
--- a/drivers/hwmon/lm70.c
+++ b/drivers/hwmon/lm70.c
@@ -178,7 +178,7 @@ static int lm70_probe(struct spi_device *spi)
struct lm70 *p_lm70;
int chip;
- of_match = of_match_device(lm70_of_ids, &spi->dev);
+ of_match = of_match_device(of_match_ptr(lm70_of_ids), &spi->dev);
if (of_match)
chip = (int)(uintptr_t)of_match->data;
else {
--
https://chromeos.dev
next prev parent reply other threads:[~2021-01-23 3:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 3:44 [PATCH v2 0/6] Stop NULLifying match pointer in of_match_device() Stephen Boyd
2021-01-23 3:44 ` [PATCH v2 1/6] media: renesas-ceu: Use of_device_get_match_data() Stephen Boyd
2021-01-25 8:30 ` Geert Uytterhoeven
2021-01-23 3:44 ` [PATCH v2 2/6] drivers: net: davinci_mdio: " Stephen Boyd
2021-01-26 13:11 ` Grygorii Strashko
2021-01-23 3:44 ` [PATCH v2 3/6] serial: stm32: " Stephen Boyd
2021-01-23 3:44 ` [PATCH v2 4/6] usb: usb251xb: " Stephen Boyd
2021-01-23 3:44 ` Stephen Boyd [this message]
2021-01-23 6:09 ` [PATCH v2 5/6] hwmon: (lm70) Avoid undefined reference to match table Guenter Roeck
2021-01-26 18:30 ` Rob Herring
2021-01-23 3:44 ` [PATCH v2 6/6] of/device: Don't NULLify match table in of_match_device() with CONFIG_OF=n Stephen Boyd
2021-01-25 8:33 ` Geert Uytterhoeven
2021-01-25 9:46 ` Arnd Bergmann
2021-01-26 18:21 ` [PATCH v2 0/6] Stop NULLifying match pointer in of_match_device() Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210123034428.2841052-6-swboyd@chromium.org \
--to=swboyd@chromium.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®