From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 68811C433E0
	for <linux-kernel@archiver.kernel.org>; Sun, 24 Jan 2021 04:09:20 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 3045722C7B
	for <linux-kernel@archiver.kernel.org>; Sun, 24 Jan 2021 04:09:19 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726475AbhAXEI4 (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Sat, 23 Jan 2021 23:08:56 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56208 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726367AbhAXEIx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 23 Jan 2021 23:08:53 -0500
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03289C0613D6
        for <linux-kernel@vger.kernel.org>; Sat, 23 Jan 2021 20:08:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=Lh9eOrCOK7bXOzdecd6q2dREsDMbVoNPQCAm58V7l6Y=; b=lFpoumH943oCQgcXSCsz6hp9Vg
        A8tXsciyoS3o/ZjeYJBZT3wxlqR+eKL9W2vX+yOhsMIUz9F83RmCkjlMlxwU1GYzaHe8mZg42jCfC
        8o21uJxrNQWLI4UB6qU1kUNvP8xwsOG7rJr/TQS32mMJaDalZBXCDl0OuBrk5JB6S632Vn5IKfntJ
        FvrNqXtnqTAYqbR5LfpD2YDa6E7JrGZEtX/vwH2uJgsuoS6lUqDljt5rVJkf7364eKYLtLlw+8fk+
        /2nXegCxdGvZH7QgtD6DGEr6LX3hOa1qGXo6mCe7dp1gBgqlQ14iAezJ7DmDuKl7CyygxjC5FmJJj
        1FoC36PQ==;
Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux))
        id 1l3Wfw-002abG-77; Sun, 24 Jan 2021 04:07:14 +0000
Date:   Sun, 24 Jan 2021 04:06:56 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Stephen Zhang <stephenzhangzsd@gmail.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memfd: replace strcpy() by strscpy()
Message-ID: <20210124040656.GB308988@casper.infradead.org>
References: <1611455017-2210-1-git-send-email-stephenzhangzsd@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1611455017-2210-1-git-send-email-stephenzhangzsd@gmail.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jan 24, 2021 at 10:23:37AM +0800, Stephen Zhang wrote:
> -	strcpy(name, MFD_NAME_PREFIX);
> +	strscpy(name, MFD_NAME_PREFIX, len + MFD_NAME_PREFIX_LEN);

This is silly.  Use memcpy() if you must remove strcpy.