From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CEBFC433E0 for ; Mon, 25 Jan 2021 17:01:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1BB722513 for ; Mon, 25 Jan 2021 17:01:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730064AbhAYRAK (ORCPT ); Mon, 25 Jan 2021 12:00:10 -0500 Received: from mx2.suse.de ([195.135.220.15]:46948 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729893AbhAYQ6x (ORCPT ); Mon, 25 Jan 2021 11:58:53 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 37825AD4E; Mon, 25 Jan 2021 16:58:10 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 98B781E14B4; Mon, 25 Jan 2021 17:58:09 +0100 (CET) Date: Mon, 25 Jan 2021 17:58:09 +0100 From: Jan Kara To: Pan Bian Cc: Jan Kara , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] isofs: release buffer head before return Message-ID: <20210125165809.GK1175@quack2.suse.cz> References: <20210118120455.118955-1-bianpan2016@163.com> <20210118144123.GC19606@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210118144123.GC19606@quack2.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 18-01-21 15:41:23, Jan Kara wrote: > On Mon 18-01-21 04:04:55, Pan Bian wrote: > > Release the buffer header before returning error code. > > > > Fixes: 2deb1acc653c ("isofs: fix access to unallocated memory when reading corrupted filesystem") > > Signed-off-by: Pan Bian > > OK, good spotting. But the other hunk in commit 2deb1acc653c seems to have > the same problem so we might fix it as well when we are at it? OK, I did this myself and picked the patch to my tree. Honza -- Jan Kara SUSE Labs, CR