From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D1B0C433DB for ; Tue, 26 Jan 2021 18:20:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05D8F207BC for ; Tue, 26 Jan 2021 18:20:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394653AbhAZSUH (ORCPT ); Tue, 26 Jan 2021 13:20:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:46116 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394427AbhAZSPp (ORCPT ); Tue, 26 Jan 2021 13:15:45 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id EE5E820780; Tue, 26 Jan 2021 18:15:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611684905; bh=3pVCU2akVCfUY9nBoClkWaDk9ECtyCUfD5m0GIsKt5g=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=KJ8iYIzfilFtTjP0Hpob5ttwArvX0gV9/sqWYrsqoZwv/8aiWpePb9+rRldIr9iCG eFWQ0G4ckxKOAPckxMeEQb5IaWuxByT6CSJFir3QiDORBD4yis0I71xzTQ6vZJzipc h4gzvq9CxBiNpkGh527AUV+iFqDwws2/wGF55+26Uo4idRy61o1bA8B/WQ1hcAyoEw K6gnhdmDxgHDmrDQfWh8jgFuVtEUviSHEHPPZI+6e8WRSpnpQTxp3EYb/f0i+M59fe mTqhwIPnxrvJ/hF6kZcgzKIhYBXt/S4DJ4GVmthx8jwl2w7mCfuM9fXoPU5O1SZEJx 2l/f4DRm2CqMg== Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 9617C352268C; Tue, 26 Jan 2021 10:15:04 -0800 (PST) Date: Tue, 26 Jan 2021 10:15:04 -0800 From: "Paul E. McKenney" To: David Gow Cc: Marco Elver , Dmitry Vyukov , boqun.feng@gmail.com, kasan-dev , Linux Kernel Mailing List Subject: Re: [PATCH 2/2] kcsan: Switch to KUNIT_CASE_PARAM for parameterized tests Message-ID: <20210126181504.GF2743@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20210113160557.1801480-1-elver@google.com> <20210113160557.1801480-2-elver@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2021 at 12:35:47PM +0800, David Gow wrote: > On Thu, Jan 14, 2021 at 12:06 AM Marco Elver wrote: > > > > Since KUnit now support parameterized tests via KUNIT_CASE_PARAM, update > > KCSAN's test to switch to it for parameterized tests. This simplifies > > parameterized tests and gets rid of the "parameters in case name" > > workaround (hack). > > > > At the same time, we can increase the maximum number of threads used, > > because on systems with too few CPUs, KUnit allows us to now stop at the > > maximum useful threads and not unnecessarily execute redundant test > > cases with (the same) limited threads as had been the case before. > > > > Cc: David Gow > > Signed-off-by: Marco Elver > > --- > > Thanks! This looks great from the KUnit point of view: I'm > particularly excited to see a use of the parameterised test generator > that's not just reading from an array. > > I tested this as well, and it all seemed to work fine for me. > > Reviewed-by: David Gow I applied both Reviewed-by tags, thank you! Thanx, Paul