From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, speakup@linux-speakup.org
Subject: Re: [PATCH] speakup: Make dectlk flush timeout configurable
Date: Thu, 28 Jan 2021 18:55:49 +0100 [thread overview]
Message-ID: <20210128175549.j5mc72mjjnh6aalk@begin> (raw)
In-Reply-To: <YBJtqGn/ZpdFpNlg@kroah.com>
Greg KH, le jeu. 28 janv. 2021 08:54:16 +0100, a ecrit:
> On Thu, Jan 28, 2021 at 12:44:44AM +0100, Samuel Thibault wrote:
> > static struct kobj_attribute full_time_attribute =
> > __ATTR(full_time, 0644, spk_var_show, spk_var_store);
> > +static struct kobj_attribute flush_time_attribute =
> > + __ATTR(flush_time, 0644, spk_var_show, spk_var_store);
>
> __ATTR_RW()?
Unfortunately no because __ATTR_RW only takes the name, and uses that
for the function to be called. In our case the functions are shared.
> Also, no Documentation/ABI/ update for the new one user-visable
> attribute? Please fix up.
Right, I'll fix it.
Samuel
prev parent reply other threads:[~2021-01-28 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 23:44 Samuel Thibault
2021-01-28 7:54 ` Greg KH
2021-01-28 17:55 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128175549.j5mc72mjjnh6aalk@begin \
--to=samuel.thibault@ens-lyon.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®