mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Valentin Schneider <valentin.schneider@arm.com>
To: linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Morten Rasmussen <morten.rasmussen@arm.com>,
	Qais Yousef <qais.yousef@arm.com>,
	Quentin Perret <qperret@google.com>,
	Pavan Kondeti <pkondeti@codeaurora.org>,
	Rik van Riel <riel@surriel.com>
Subject: [PATCH 8/8] sched/fair: Relax task_hot() for misfit tasks
Date: Thu, 28 Jan 2021 18:31:41 +0000	[thread overview]
Message-ID: <20210128183141.28097-9-valentin.schneider@arm.com> (raw)
In-Reply-To: <20210128183141.28097-1-valentin.schneider@arm.com>

Misfit tasks can and will be preempted by the stopper to migrate them over
to a higher-capacity CPU. However, when runnable but not current misfit
tasks are scanned by the load balancer (i.e. detach_tasks()), the
task_hot() ratelimiting logic may prevent us from enqueuing said task onto
a higher-capacity CPU.

Align detach_tasks() with the active-balance logic and let it pick a
cache-hot misfit task when the destination CPU can provide a capacity
uplift.

Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
---
 kernel/sched/fair.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index cba9f97d9beb..c2351b87824f 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -7484,6 +7484,17 @@ static int task_hot(struct task_struct *p, struct lb_env *env)
 	if (env->sd->flags & SD_SHARE_CPUCAPACITY)
 		return 0;
 
+	/*
+	 * On a (sane) asymmetric CPU capacity system, the increase in compute
+	 * capacity should offset any potential performance hit caused by a
+	 * migration.
+	 */
+	if (sd_has_asym_cpucapacity(env->sd) &&
+	    env->idle != CPU_NOT_IDLE &&
+	    !task_fits_capacity(p, capacity_of(env->src_cpu)) &&
+	    cpu_capacity_greater(env->dst_cpu, env->src_cpu))
+		return 0;
+
 	/*
 	 * Buddy candidates are cache hot:
 	 */
-- 
2.27.0


  parent reply	other threads:[~2021-01-28 18:41 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28 18:31 [PATCH 0/8] sched/fair: misfit task load-balance tweaks Valentin Schneider
2021-01-28 18:31 ` [PATCH 1/8] sched/fair: Clean up active balance nr_balance_failed trickery Valentin Schneider
2021-02-03 15:14   ` Qais Yousef
2021-02-03 18:42     ` Valentin Schneider
2021-02-04 15:05       ` Qais Yousef
2021-02-05 13:51   ` Vincent Guittot
2021-02-05 14:05     ` Valentin Schneider
2021-02-05 14:34       ` Vincent Guittot
2021-01-28 18:31 ` [PATCH 2/8] sched/fair: Add more sched_asym_cpucapacity static branch checks Valentin Schneider
2021-02-03 15:14   ` Qais Yousef
2021-02-09  8:42   ` Vincent Guittot
2021-01-28 18:31 ` [PATCH 3/8] sched/fair: Tweak misfit-related capacity checks Valentin Schneider
2021-02-03 15:15   ` Qais Yousef
2021-02-03 18:42     ` Valentin Schneider
2021-02-05 14:31   ` Vincent Guittot
2021-02-05 16:59     ` Valentin Schneider
2021-02-05 17:17       ` Vincent Guittot
2021-02-05 20:07         ` Valentin Schneider
2021-02-08 15:29           ` Vincent Guittot
2021-02-08 17:49             ` Valentin Schneider
2021-01-28 18:31 ` [PATCH 4/8] sched/fair: Use dst_cpu's capacity rather than group {min, max} capacity Valentin Schneider
2021-02-03 15:15   ` Qais Yousef
2021-01-28 18:31 ` [PATCH 5/8] sched/fair: Make check_misfit_status() only compare dynamic capacities Valentin Schneider
2021-02-03 15:15   ` Qais Yousef
2021-02-04 10:49     ` Dietmar Eggemann
2021-02-04 11:34       ` Valentin Schneider
2021-02-04 14:57         ` Dietmar Eggemann
2021-01-28 18:31 ` [PATCH 6/8] sched/fair: Filter out locally-unsolvable misfit imbalances Valentin Schneider
2021-02-03 15:16   ` Qais Yousef
2021-02-03 18:43     ` Valentin Schneider
2021-01-28 18:31 ` [PATCH 7/8] sched/fair: Attempt misfit active balance when migration_type != migrate_misfit Valentin Schneider
2021-02-03 15:16   ` Qais Yousef
2021-02-03 18:43     ` Valentin Schneider
2021-02-04 11:44       ` Dietmar Eggemann
2021-02-04 12:22         ` Valentin Schneider
2021-02-09  8:58   ` Vincent Guittot
2021-02-09 18:19     ` Valentin Schneider
2021-01-28 18:31 ` Valentin Schneider [this message]
2021-02-03 15:17   ` [PATCH 8/8] sched/fair: Relax task_hot() for misfit tasks Qais Yousef
2021-02-08 16:21   ` Vincent Guittot
2021-02-08 18:24     ` Valentin Schneider
2021-02-09  8:56       ` Vincent Guittot
2021-02-03 15:14 ` [PATCH 0/8] sched/fair: misfit task load-balance tweaks Qais Yousef
2021-02-03 18:43   ` Valentin Schneider
2021-02-04 12:03     ` Dietmar Eggemann
2021-02-04 12:36       ` Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210128183141.28097-9-valentin.schneider@arm.com \
    --to=valentin.schneider@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=morten.rasmussen@arm.com \
    --cc=peterz@infradead.org \
    --cc=pkondeti@codeaurora.org \
    --cc=qais.yousef@arm.com \
    --cc=qperret@google.com \
    --cc=riel@surriel.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome