From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>,
linux-hardening@vger.kernel.org,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Justin Forbes <jforbes@redhat.com>,
Ondrej Mosnacek <omosnace@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Christoph Hellwig <hch@infradead.org>,
Miroslav Benes <mbenes@suse.cz>,
David Laight <David.Laight@aculab.com>,
Jessica Yu <jeyu@kernel.org>
Subject: Re: [PATCH RFC] kbuild: Prevent compiler mismatch with external modules
Date: Thu, 28 Jan 2021 15:34:09 -0600 [thread overview]
Message-ID: <20210128213409.qxnclchjyq6v23up@treble> (raw)
In-Reply-To: <CAHk-=wh+3PWi2NuoQ0hbSyLpOHjaBWKcgX6N7+PfPkXzNAfMwA@mail.gmail.com>
On Thu, Jan 28, 2021 at 01:23:11PM -0800, Linus Torvalds wrote:
> On Thu, Jan 28, 2021 at 1:03 PM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > I really think the whole compiler version check is purely voodoo programming.
>
> .. but there are obviously potentially things we - in the kernel - do
> that may make certain compiler versions incompatible. We long long ago
> used to have things like "you can't have an empty struct because gcc
> version x.y.z doesn't support it", so even a UP spinlock would be
>
> typedef struct { int gcc_is_buggy; } raw_spinlock_t;
>
> but only if you compiled it with a version of gcc older than 3.0. So
> compiling one file with one compiler, and another with a newer one,
> would result in the data structures simply not having the same layout.
>
> That's not because of compiler versions per se, it's because of our
> version checks.
Right, this is what I'm trying to say. We have features based on
compiler version checks. Peterz pointed out asm goto as a previous
example.
> THAT workaround is long gone, but I didn't check what other ones we
> might have now. But the gcc version checks we _do_ have are not
> necessarily about major versions at all (ie I trivially found checks
> for 4.9, 4.9.2, 5.1, 7.2 and 9.1).
Then maybe the check should be same major.minor?
And convert it to a strongly worded warning/disclaimer?
--
Josh
next prev parent reply other threads:[~2021-01-28 21:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 20:08 Josh Poimboeuf
2021-01-28 20:24 ` Linus Torvalds
2021-01-28 20:52 ` Josh Poimboeuf
2021-01-28 21:03 ` Linus Torvalds
2021-01-28 21:23 ` Linus Torvalds
2021-01-28 21:34 ` Josh Poimboeuf [this message]
2021-01-28 21:45 ` Linus Torvalds
2021-01-28 22:08 ` Josh Poimboeuf
2021-01-28 23:17 ` Masahiro Yamada
2021-02-01 21:13 ` Josh Poimboeuf
2021-03-05 16:28 ` Masahiro Yamada
2021-03-05 19:24 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128213409.qxnclchjyq6v23up@treble \
--to=jpoimboe@redhat.com \
--cc=David.Laight@aculab.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jeyu@kernel.org \
--cc=jforbes@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mbenes@suse.cz \
--cc=michal.lkml@markovi.net \
--cc=omosnace@redhat.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®