From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EEA2C433DB for ; Sat, 30 Jan 2021 16:24:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EF9464DF5 for ; Sat, 30 Jan 2021 16:24:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232013AbhA3QYo (ORCPT ); Sat, 30 Jan 2021 11:24:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:43194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231740AbhA3Om4 (ORCPT ); Sat, 30 Jan 2021 09:42:56 -0500 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B605264E10; Sat, 30 Jan 2021 14:42:12 +0000 (UTC) Date: Sat, 30 Jan 2021 09:42:11 -0500 From: Steven Rostedt To: Alexey Kardashevskiy Cc: LKML , Mathieu Desnoyers , Matt Mullins , paulmck , Ingo Molnar , Alexei Starovoitov , Daniel Borkmann , Dmitry Vyukov , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Kees Cook , Peter Zijlstra , Josh Poimboeuf Subject: Re: [PATCH v5] tracepoint: Do not fail unregistering a probe due to memory failure Message-ID: <20210130094211.719f03a6@oasis.local.home> In-Reply-To: <20210130093626.0b7b3b1b@oasis.local.home> References: <20210127170721.58bce7cc@gandalf.local.home> <20210130093626.0b7b3b1b@oasis.local.home> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 30 Jan 2021 09:36:26 -0500 Steven Rostedt wrote: > Do you still have the same crash with v3 (that's the one I'm going to > go with for now.) > > https://lore.kernel.org/r/20201118093405.7a6d2290@gandalf.local.home Just curious, does the following patch fix it for v5? -- Steve diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c index 7261fa0f5e3c..cf3a6d104fdb 100644 --- a/kernel/tracepoint.c +++ b/kernel/tracepoint.c @@ -306,6 +306,7 @@ static int tracepoint_remove_func(struct tracepoint *tp, tp->unregfunc(); static_key_disable(&tp->key); + tracepoint_synchronize_unregister(); rcu_assign_pointer(tp->funcs, tp_funcs); } else { rcu_assign_pointer(tp->funcs, tp_funcs);