From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75412C433E0 for ; Sat, 30 Jan 2021 15:57:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 452F260C41 for ; Sat, 30 Jan 2021 15:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232295AbhA3P5c (ORCPT ); Sat, 30 Jan 2021 10:57:32 -0500 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:60504 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230085AbhA3Pzh (ORCPT ); Sat, 30 Jan 2021 10:55:37 -0500 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 10UFNtbL032436; Sat, 30 Jan 2021 09:28:52 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=fx3dkMJOLSIWNaFDZpEzH9Ayv8+vFheSBmg7vPaoZAY=; b=H/ADGv7dBadeen5KXtwLE3d4vd7T0aK/MkB8Iv+yMQs8jshzwELzFp+1xcXBEh3SMyoI sRoL/nTF3TahcWsdS3LfvnyzEMSBXetLKLhcNdPkSma67xgHIP8RhURhnYk6WXryNpSg fB9cFKUCeOrfV5cfgdlwjojA6B6E8RUVzsmcMpRSspPuqT6kieNZrPa5IRwiwmoSKRrx DYIUjE9uEVEyL8jMlC11INb7V1OxHMBUEKHNCuwOZeLdZoXwtRGRbCI0kbV3RKrHMbjw eJtFQ0nBZD2MKEG23c23qMlSKEhCPP+7rxN3270Bk4qg9dW9RmW/QBuh5wWYbmgnFbME Eg== Received: from ediex02.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 36d4rtg65c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Sat, 30 Jan 2021 09:28:52 -0600 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Sat, 30 Jan 2021 15:28:50 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.1913.5 via Frontend Transport; Sat, 30 Jan 2021 15:28:50 +0000 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id A31D045; Sat, 30 Jan 2021 15:28:50 +0000 (UTC) Date: Sat, 30 Jan 2021 15:28:50 +0000 From: Charles Keepax To: Hans de Goede CC: Lee Jones , Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , Mark Brown , , , Andy Shevchenko , Subject: Re: [PATCH v4 10/13] ASoC: arizona-jack: Use snd_soc_jack to report jack events Message-ID: <20210130152850.GU106851@ediswmail.ad.cirrus.com> References: <20210123121313.79530-1-hdegoede@redhat.com> <20210123121720.79863-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210123121720.79863-1-hdegoede@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 mlxscore=0 mlxlogscore=999 impostorscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 phishscore=0 clxscore=1015 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101300085 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 23, 2021 at 01:17:17PM +0100, Hans de Goede wrote: > Use the snd_soc_jack code to report jack events, instead of using extcon > for reporting the cable-type + an input_dev for reporting the button > presses. > > The snd_soc_jack code will report the cable-type through both input_dev > events and through ALSA controls and the button-presses through input_dev > events. > > Note that this means that when the codec drivers are moved over to use > the new arizona-jack.c library code instead of having a separate MFD > extcon cell with the extcon-arizona.c driver, we will no longer report > extcon events to userspace for cable-type changes. This should not be > a problem since "standard" Linux distro userspace does not (and has > never) used the extcon class interface for this. Android does have > support for the extcon class interface, but that was introduced in > the same release as support for input_dev cable-type events, so this > should not be a problem for Android either. > > Note this also reduces ARIZONA_MAX_MICD_RANGE from 8 to 6, this is > ok to do since this info is always provided through pdata (or defaults) > and cannot be overridden from devicetree. All in-kernel users of the > pdata (and the fallback defaults) define 6 or less buttons/ranges. > > Reviewed-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- Acked-by: Charles Keepax Tested-by: Charles Keepax Thanks, Charles