From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0CB3C433E0 for ; Mon, 1 Feb 2021 08:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A534364DFA for ; Mon, 1 Feb 2021 08:31:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232384AbhBAIbd (ORCPT ); Mon, 1 Feb 2021 03:31:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:50794 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231748AbhBAIbb (ORCPT ); Mon, 1 Feb 2021 03:31:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612168204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9abuyB1cdyK0EkjXW3R63neo8lvwSJKL9r9wYH7jDK8=; b=XD0KJrvYdfH25geq1Jpy+AQL2G4WkbqThbv4ICIoasXN3zztxVGXJC2J7G4CsMCVQ1fBc5 bp/BZQBXdvmC69luTKpS593UMmdyS+NC8Igt43JGK0SLdiWNL2ggurer4A/cvuFzs56anF 5KQNy+8D0RXCrSymLdoXGKOcvvaSiNo= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-120-zSAqnJcRM_y8R34WmERvpw-1; Mon, 01 Feb 2021 03:30:02 -0500 X-MC-Unique: zSAqnJcRM_y8R34WmERvpw-1 Received: by mail-wm1-f72.google.com with SMTP id s10so4248485wme.8 for ; Mon, 01 Feb 2021 00:30:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9abuyB1cdyK0EkjXW3R63neo8lvwSJKL9r9wYH7jDK8=; b=BaMvkyRllCjACGOCctasR4s9JPJzjHwm63y70dAeXpS/MPG9PZ1VlqNLAo9MUe2Mnb 7d1eeth0Og38n9QTi5vujPSQBouBsBKBkUNg2MnUXuhbVdgFXnB75RQ3gU85LxYdbl7R 4V9zefX8AZw/B2gBD2PaOzuDgdE+lpPtephhgO4Y1/9+2F7SHq5sUiSWHnjQE+13faJT OMHlKx6VE+EGbNQuGOwaLltqbEG5I4u7Z3afRCyzmgnQqgH7Xuf49zpyVkHmANcsm+7f odcuHDcSlRChYSKC7+DjnMispWcFl96BMdXJrlvcFw3cKh24exAw3YCzzg7Q3SeEvMAL 9oGg== X-Gm-Message-State: AOAM53032zy5u+hXs25wmH9RRLZjiFQxrj9tC9S3SXc28eOGp0kB+CJj oDDGUIb/6Hud5ooUPfekp+NCXfl29BCEu6v+HyL5PAyL7/u48NCyGCg5EDu/7nqvT1j0vNvCMn9 DspQ4auUvKQp7lcFiafgpqsCi X-Received: by 2002:a05:6000:1045:: with SMTP id c5mr17350737wrx.250.1612168201727; Mon, 01 Feb 2021 00:30:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJz6UZr189pCeRP1YezATVaXeQQHRGHCvETS8Jr7AzP2dFOuy5pRO24CAZQYIXQgraHCwm17sg== X-Received: by 2002:a05:6000:1045:: with SMTP id c5mr17350715wrx.250.1612168201566; Mon, 01 Feb 2021 00:30:01 -0800 (PST) Received: from steredhat (host-79-34-249-199.business.telecomitalia.it. [79.34.249.199]) by smtp.gmail.com with ESMTPSA id w14sm25577889wro.86.2021.02.01.00.30.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 00:30:00 -0800 (PST) Date: Mon, 1 Feb 2021 09:29:58 +0100 From: Stefano Garzarella To: Max Gurtovoy Cc: virtualization@lists.linux-foundation.org, Xie Yongji , "Michael S. Tsirkin" , Laurent Vivier , Stefan Hajnoczi , linux-kernel@vger.kernel.org, Jason Wang , kvm@vger.kernel.org Subject: Re: [PATCH RFC v2 08/10] vdpa: add vdpa simulator for block device Message-ID: <20210201082958.646etcwgssvi22cq@steredhat> References: <20210128144127.113245-1-sgarzare@redhat.com> <20210128144127.113245-9-sgarzare@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 31, 2021 at 05:31:43PM +0200, Max Gurtovoy wrote: > >On 1/28/2021 4:41 PM, Stefano Garzarella wrote: >>From: Max Gurtovoy >> >>This will allow running vDPA for virtio block protocol. >> >>Signed-off-by: Max Gurtovoy >>[sgarzare: various cleanups/fixes] >>Signed-off-by: Stefano Garzarella >>--- >>v2: >>- rebased on top of other changes (dev_attr, get_config(), notify(), etc.) >>- memset to 0 the config structure in vdpasim_blk_get_config() >>- used vdpasim pointer in vdpasim_blk_get_config() >> >>v1: >>- Removed unused headers >>- Used cpu_to_vdpasim*() to store config fields >>- Replaced 'select VDPA_SIM' with 'depends on VDPA_SIM' since selected >> option can not depend on other [Jason] >>- Start with a single queue for now [Jason] >>- Add comments to memory barriers >>--- >> drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 145 +++++++++++++++++++++++++++ >> drivers/vdpa/Kconfig | 7 ++ >> drivers/vdpa/vdpa_sim/Makefile | 1 + >> 3 files changed, 153 insertions(+) >> create mode 100644 drivers/vdpa/vdpa_sim/vdpa_sim_blk.c >> >>diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c >>new file mode 100644 >>index 000000000000..999f9ca0b628 >>--- /dev/null >>+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c >>@@ -0,0 +1,145 @@ >>+// SPDX-License-Identifier: GPL-2.0-only >>+/* >>+ * VDPA simulator for block device. >>+ * >>+ * Copyright (c) 2020, Mellanox Technologies. All rights reserved. > >I guess we can change the copyright from Mellanox to: > >Copyright (c) 2020, NVIDIA CORPORATION. All rights reserved. I'll update in the next version. Thanks, Stefano