From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C679C433E6 for ; Mon, 1 Feb 2021 09:24:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B1CD64E30 for ; Mon, 1 Feb 2021 09:24:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232713AbhBAJYJ (ORCPT ); Mon, 1 Feb 2021 04:24:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232543AbhBAJYG (ORCPT ); Mon, 1 Feb 2021 04:24:06 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 873E0C06174A for ; Mon, 1 Feb 2021 01:23:26 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6VQU-0002Sl-BI; Mon, 01 Feb 2021 10:23:18 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1l6VQT-0006zv-0x; Mon, 01 Feb 2021 10:23:17 +0100 Date: Mon, 1 Feb 2021 10:23:17 +0100 From: Michael Tretter To: David Laight Cc: 'Emmanuel Arias' , "kernel@pengutronix.de" , "mchehab@kernel.org" , "gregkh@linuxfoundation.org" , "linux-media@vger.kernel.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] media: allegro-dvt: Use __packed sentence Message-ID: <20210201092317.GB6717@pengutronix.de> Mail-Followup-To: Michael Tretter , David Laight , 'Emmanuel Arias' , "kernel@pengutronix.de" , "mchehab@kernel.org" , "gregkh@linuxfoundation.org" , "linux-media@vger.kernel.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" References: <63a4ed5c2ef54c09b2df9d6234b68711@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <63a4ed5c2ef54c09b2df9d6234b68711@AcuMS.aculab.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:09:54 up 60 days, 21:36, 100 users, load average: 0.07, 0.20, 0.21 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Jan 2021 23:54:41 +0000, David Laight wrote: > From: Emmanuel Arias > > Sent: 29 January 2021 20:02 > > > > Fix coding style using __packed sentece instead of > > __attribute__((__packed__)). > > > > Signed-off-by: Emmanuel Arias > > --- > > drivers/staging/media/allegro-dvt/allegro-core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/media/allegro-dvt/allegro-core.c b/drivers/staging/media/allegro- > > dvt/allegro-core.c > > index 9f718f43282b..cee624dac61a 100644 > > --- a/drivers/staging/media/allegro-dvt/allegro-core.c > > +++ b/drivers/staging/media/allegro-dvt/allegro-core.c > > @@ -670,7 +670,7 @@ static ssize_t allegro_mbox_read(struct allegro_mbox *mbox, > > struct { > > u16 length; > > u16 type; > > - } __attribute__ ((__packed__)) *header; > > + } __packed *header; > > struct regmap *sram = mbox->dev->sram; > > Does this actually need to be packed? > The only reason would be if the structure could exist on a 2n+1 > boundary. Not sure, what you mean by this. > But that is only likely if part of some binary sequence. > In which case I'd expect it to be marked __be or __le. It is part of a binary sequence. It is the header of messages in a mailbox that is used to exchange data with a co-processor (video encoder). In fact, it should be marked as __le. Michael