From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF01EC433DB for ; Mon, 1 Feb 2021 13:07:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9392464EA2 for ; Mon, 1 Feb 2021 13:07:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231913AbhBANHG (ORCPT ); Mon, 1 Feb 2021 08:07:06 -0500 Received: from mga09.intel.com ([134.134.136.24]:13861 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231821AbhBANGl (ORCPT ); Mon, 1 Feb 2021 08:06:41 -0500 IronPort-SDR: frxP/wnYac5hPXbtAQ2JLNpPTp5yLgawip68681SggrivcA6cz/wU9BfFVhHTGnK2u2J8g21VE 0y7jHWb5HplA== X-IronPort-AV: E=McAfee;i="6000,8403,9881"; a="180824718" X-IronPort-AV: E=Sophos;i="5.79,392,1602572400"; d="scan'208";a="180824718" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 05:04:54 -0800 IronPort-SDR: AK4THoZJYK1Ba5XswMeCZXCVcRC0dQrby+5U0//H7DsBxhDH3/Tco4eNOfDNI3LjNuNy/zTBQe v0JS8fA0VJNw== X-IronPort-AV: E=Sophos;i="5.79,392,1602572400"; d="scan'208";a="355759930" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 05:04:51 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id A03A42074F; Mon, 1 Feb 2021 15:04:47 +0200 (EET) Date: Mon, 1 Feb 2021 15:04:47 +0200 From: Sakari Ailus To: Paul Kocialkowski Cc: Julia Lawall , Mauro Carvalho Chehab , linux-media@vger.kernel.org, =?iso-8859-1?Q?K=E9vin_L'h=F4pital?= , linux-kernel@vger.kernel.org, Linux Memory Management List , kbuild-all@lists.01.org Subject: Re: [PATCH] media: i2c: fix odd_ptr_err.cocci warnings Message-ID: <20210201130447.GN32460@paasikivi.fi.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 18, 2021 at 02:55:07PM +0100, Paul Kocialkowski wrote: > Hi, > > On Sat 16 Jan 21, 21:11, Julia Lawall wrote: > > From: kernel test robot > > > > PTR_ERR should access the value just tested by IS_ERR > > Good catch! > > Reviewed-by: Paul Kocialkowski Thanks, Julia and Paul. A patch with similar content got recently merged: commit 6e7cca2790a54057ddf64da7843271e192f71ca0 Author: Hans Verkuil Date: Wed Jan 20 09:42:38 2021 +0100 media: i2c/ov8865.c: fix error checks using wrong variable Fix two typos: dvdd -> dovdd and dvdd -> avdd Both clearly copy-and-paste mistakes. Fixes this smatch warning: drivers/media/i2c/ov8865.c:2852 ov8865_probe() warn: passing zero to 'PTR_ERR' Signed-off-by: Hans Verkuil Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Mauro Carvalho Chehab -- Kind regards, Sakari Ailus