From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D3FDC433DB for ; Tue, 2 Feb 2021 08:23:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8BF564ED4 for ; Tue, 2 Feb 2021 08:23:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232619AbhBBIXv (ORCPT ); Tue, 2 Feb 2021 03:23:51 -0500 Received: from mga05.intel.com ([192.55.52.43]:4860 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231324AbhBBIXW (ORCPT ); Tue, 2 Feb 2021 03:23:22 -0500 IronPort-SDR: TjiajcQu8hiWbokg6NvcsRgCRx6oi9x9GDItJ8GtCMocRS04jbVY/rH6YAXORY8cbzOuZegX2b XMABRm7vjbuw== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="265649233" X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="265649233" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 00:21:36 -0800 IronPort-SDR: WAnMADibO6TaXQ29FfB/fxgl6lF2DbEN/KLanN7lHaF/PIxH6zZ25JwiYMxZX4I1aInMm5UsN+ y3mv8IKyRBig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="479481555" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 02 Feb 2021 00:21:34 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 02 Feb 2021 10:21:33 +0200 Date: Tue, 2 Feb 2021 10:21:33 +0200 From: Heikki Krogerus To: Badhri Jagan Sridharan Cc: Guenter Roeck , Greg Kroah-Hartman , Kyle Tso , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] usb: typec: tcpm: Handle vbus shutoff when in source mode Message-ID: <20210202082133.GB1433721@kuha.fi.intel.com> References: <20210201100212.49863-1-badhri@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210201100212.49863-1-badhri@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 01, 2021 at 02:02:12AM -0800, Badhri Jagan Sridharan wrote: > While in source mode, vbus could be shutoff by protections > circuits. TCPM does not move back to toggling state to > re-initiate connection. Fix this by moving to SRC_UNATTACHED > state when vbus shuts off while in source mode. > > Signed-off-by: Badhri Jagan Sridharan Reviewed-by: Heikki Krogerus > --- > drivers/usb/typec/tcpm/tcpm.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index 0afd8ef692e8..ff0732c12b8a 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -4897,6 +4897,17 @@ static void _tcpm_pd_vbus_off(struct tcpm_port *port) > /* Do nothing, waiting for sink detection */ > break; > > + case SRC_STARTUP: > + case SRC_SEND_CAPABILITIES: > + case SRC_SEND_CAPABILITIES_TIMEOUT: > + case SRC_NEGOTIATE_CAPABILITIES: > + case SRC_TRANSITION_SUPPLY: > + case SRC_READY: > + case SRC_WAIT_NEW_CAPABILITIES: > + /* Force to unattached state to re-initiate connection */ > + tcpm_set_state(port, SRC_UNATTACHED, 0); > + break; > + > case PORT_RESET: > /* > * State set back to default mode once the timer completes. > -- > 2.30.0.365.g02bc693789-goog thanks, -- heikki