mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Firo Yang <firo.yang@suse.com>
To: Jorgen Hansen <jhansen@vmware.com>
Cc: linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, pv-drivers@vmware.com,
	gregkh@linuxfoundation.org
Subject: Re: [PATCH v2 1/3] VMCI: Stop log spew when qp allocation isn't possible
Date: Tue, 2 Feb 2021 17:57:37 +0800	[thread overview]
Message-ID: <20210202095737.shlt4sjsdriq2qc3@suse.com> (raw)
In-Reply-To: <1611160340-30158-1-git-send-email-jhansen@vmware.com>

The 01/20/2021 08:32, Jorgen Hansen wrote:
> VMCI queue pair allocation is disabled, if a VM is in FT mode. In
> these cases, VMware Tools may still once in a while attempt to
> create a vSocket stream connection, resulting in multiple
> warnings in the kernel logs. Therefore downgrade the error log to
> a debug log.
> 
> Reviewed-by: Vishnu Dasa <vdasa@vmware.com>
> Signed-off-by: Jorgen Hansen <jhansen@vmware.com>
> ---
>  drivers/misc/vmw_vmci/vmci_queue_pair.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> index c490658..a3691c1 100644
> --- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
> +++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> @@ -1207,7 +1207,7 @@ static int qp_alloc_guest_work(struct vmci_handle *handle,
>  	} else {
>  		result = qp_alloc_hypercall(queue_pair_entry);
>  		if (result < VMCI_SUCCESS) {
> -			pr_warn("qp_alloc_hypercall result = %d\n", result);
> +			pr_devel("qp_alloc_hypercall result = %d\n", result);

Hi Jorgen, recently, our customer reported that their dmesg was also
swamped by the following message along with the message above. 

  "Could not attach to queue pair with -20"

This message was printed by vmci_transport_queue_pair_alloc(). Could
we also eliminate it?

Thanks,
Firo


>  			goto error;
>  		}
>  	}
> -- 
> 2.6.2
> 
> _______________________________________________
> Virtualization mailing list
> Virtualization@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization


      reply	other threads:[~2021-02-02 10:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 16:32 Jorgen Hansen
2021-02-02  9:57 ` Firo Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210202095737.shlt4sjsdriq2qc3@suse.com \
    --to=firo.yang@suse.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jhansen@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pv-drivers@vmware.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®