From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12594C433E0 for ; Thu, 4 Feb 2021 14:14:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E00DA64F3F for ; Thu, 4 Feb 2021 14:13:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236608AbhBDONk (ORCPT ); Thu, 4 Feb 2021 09:13:40 -0500 Received: from elvis.franken.de ([193.175.24.41]:52103 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236549AbhBDOBV (ORCPT ); Thu, 4 Feb 2021 09:01:21 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1l7fBQ-0004tX-01; Thu, 04 Feb 2021 15:00:32 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 0E11CC0D54; Thu, 4 Feb 2021 15:00:07 +0100 (CET) Date: Thu, 4 Feb 2021 15:00:07 +0100 From: Thomas Bogendoerfer To: Florian Fainelli , Paul Burton , John Crispin , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH] MIPS: of: Introduce helper function to get DTB Message-ID: <20210204140006.GB13761@alpha.franken.de> References: <20210127132431.143374-1-tsbogend@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210127132431.143374-1-tsbogend@alpha.franken.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 27, 2021 at 02:24:30PM +0100, Thomas Bogendoerfer wrote: > Selection of the DTB to be used was burried in more or less readable > code in head.S. Move this code into a inline helper function and > use it. > > Signed-off-by: Thomas Bogendoerfer > --- > arch/mips/ath79/setup.c | 13 +++++------ > arch/mips/bmips/setup.c | 7 +++--- > arch/mips/generic/init.c | 5 ++--- > arch/mips/include/asm/bootinfo.h | 22 ++++++++++++++++++- > arch/mips/include/asm/octeon/octeon.h | 1 - > arch/mips/kernel/head.S | 31 --------------------------- > arch/mips/kernel/setup.c | 4 ---- > arch/mips/lantiq/prom.c | 7 ++---- > arch/mips/pic32/pic32mzda/init.c | 15 +------------ > arch/mips/ralink/of.c | 11 +++------- > 10 files changed, 39 insertions(+), 77 deletions(-) applied to mips-next. Thomas, -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]