mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Sven Schuchmann <schuchmann@schleissheimer.de>
Cc: Dan Murphy <dmurphy@ti.com>,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT
Date: Thu, 4 Feb 2021 15:53:08 +0100	[thread overview]
Message-ID: <20210204145308.GC14305@duo.ucw.cz> (raw)
In-Reply-To: <20210204143738.28036-1-schuchmann@schleissheimer.de>

[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]

On Thu 2021-02-04 14:37:38, Sven Schuchmann wrote:
> In order to use a multicolor-led together with a trigger
> the led needs to have an intensity set to see something.
> The trigger changes the brightness of the led but if there
> is no intensity we actually see nothing.
> 
> This patch adds the ability to set the default intensity
> of each multi-led node so that it is turned on from DT.
> If no intensity is given the led will be initialized
> with full intensity.



> diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
> index f13117eed976..4b40bf66483c 100644
> --- a/drivers/leds/leds-lp50xx.c
> +++ b/drivers/leds/leds-lp50xx.c
> @@ -267,7 +267,6 @@ struct lp50xx_led {
>  	struct led_classdev_mc mc_cdev;
>  	struct lp50xx *priv;
>  	unsigned long bank_modules;
> -	int led_intensity[LP50XX_LEDS_PER_MODULE];
>  	u8 ctrl_bank_enabled;
>  	int led_number;
>  };

? Does not make sense and changelog does not help.
							Pavel

-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2021-02-04 14:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 14:37 Sven Schuchmann
2021-02-04 14:53 ` Pavel Machek [this message]
2021-02-05  9:59   ` AW: " Sven Schuchmann
2021-02-05 10:34     ` Pavel Machek
2021-02-05 11:21       ` AW: " Sven Schuchmann
2021-02-19 11:16         ` Pavel Machek
2021-02-19 11:38           ` AW: " Sven Schuchmann
2021-02-19 13:55             ` Andy Shevchenko
2021-02-19 14:09               ` AW: " Sven Schuchmann
2021-02-19 14:50                 ` Andy Shevchenko
2021-02-19 14:18           ` Andy Shevchenko
2021-02-19 18:07             ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204145308.GC14305@duo.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=dmurphy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=schuchmann@schleissheimer.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®