From: Andreas Oetken <ennoerlangen@googlemail.com>
To: Ley Foon Tan <ley.foon.tan@intel.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
linux-kernel@vger.kernel.org
Cc: Andreas Oetken <ennoerlangen@gmail.com>,
Andreas Oetken <andreas.oetken@siemens.com>
Subject: [PATCH] nios2: fixed broken sys_clone syscall
Date: Fri, 5 Feb 2021 09:23:38 +0100 [thread overview]
Message-ID: <20210205082338.584931-1-ennoerlangen@gmail.com> (raw)
From: Andreas Oetken <andreas.oetken@siemens.com>
The tls pointer must be pushed on the stack prior to calling nios2_clone
as it is the 5th function argument. Prior handling of the tls pointer was
done inside former called function copy_thread_tls using the r8 register
from the current_pt_regs directly. This was a bad design and resulted in
the current bug introduced in 04bd52fb.
Fixes: 04bd52fb ("nios2: enable HAVE_COPY_THREAD_TLS, switch to kernel_clone_args")
Signed-off-by: Andreas Oetken <andreas.oetken@siemens.com>
---
arch/nios2/kernel/entry.S | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/nios2/kernel/entry.S b/arch/nios2/kernel/entry.S
index da8442450e46..0794cd7803df 100644
--- a/arch/nios2/kernel/entry.S
+++ b/arch/nios2/kernel/entry.S
@@ -389,7 +389,10 @@ ENTRY(ret_from_interrupt)
*/
ENTRY(sys_clone)
SAVE_SWITCH_STACK
+ subi sp, sp, 4 /* make space for tls pointer */
+ stw r8, 0(sp) /* pass tls pointer (r8) via stack (5th argument) */
call nios2_clone
+ addi sp, sp, 4
RESTORE_SWITCH_STACK
ret
--
2.30.0
next reply other threads:[~2021-02-05 8:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 8:23 Andreas Oetken [this message]
2021-02-05 8:38 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205082338.584931-1-ennoerlangen@gmail.com \
--to=ennoerlangen@googlemail.com \
--cc=andreas.oetken@siemens.com \
--cc=christian.brauner@ubuntu.com \
--cc=ennoerlangen@gmail.com \
--cc=ley.foon.tan@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®