From: Herbert Xu <herbert@gondor.apana.org.au>
To: Longfang Liu <liulongfang@huawei.com>
Cc: wangzhou1@hisilicon.com, xuzaibo@huawei.com,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH 3/3] crypto: hisilicon/sec - fixes shash test error
Date: Fri, 5 Feb 2021 22:44:35 +1100 [thread overview]
Message-ID: <20210205114435.GA17031@gondor.apana.org.au> (raw)
In-Reply-To: <1612519857-30714-4-git-send-email-liulongfang@huawei.com>
On Fri, Feb 05, 2021 at 06:10:57PM +0800, Longfang Liu wrote:
> If this configuration item is not turned on,
> the allocation of crypto_tfm will fail when
> the shash algorithm calculates the hash
> through the software.
>
> Signed-off-by: Longfang Liu <liulongfang@huawei.com>
> ---
> arch/arm64/configs/defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 8383016..7cfc9b6 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -117,7 +117,7 @@ CONFIG_KVM=y
> CONFIG_ARM64_CRYPTO=y
> CONFIG_CRYPTO_SHA1_ARM64_CE=y
> CONFIG_CRYPTO_SHA2_ARM64_CE=y
> -CONFIG_CRYPTO_SHA512_ARM64_CE=m
> +CONFIG_CRYPTO_SHA512_ARM64_CE=y
If this is truly needed then it should be enabled through Kconfig.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2021-02-05 11:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 10:10 [PATCH 0/3] crypto:hisilicon/sec - fixes some coding style Longfang Liu
2021-02-05 10:10 ` [PATCH 1/3] crypto: hisilicon/sec - fixes some log printing style Longfang Liu
2021-02-05 10:10 ` [PATCH 2/3] crypto: hisilicon/sec - fixes some driver coding style Longfang Liu
2021-02-05 10:10 ` [PATCH 3/3] crypto: hisilicon/sec - fixes shash test error Longfang Liu
2021-02-05 11:44 ` Herbert Xu [this message]
2021-02-07 2:46 ` liulongfang
2021-02-07 8:02 ` Ard Biesheuvel
2021-02-07 9:49 ` liulongfang
2021-02-20 9:51 ` liulongfang
2021-03-04 4:41 ` Herbert Xu
2021-03-04 5:56 ` liulongfang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205114435.GA17031@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ardb@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liulongfang@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®