From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96239C433E6 for ; Mon, 8 Feb 2021 21:30:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4370864E6F for ; Mon, 8 Feb 2021 21:30:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236842AbhBHVac (ORCPT ); Mon, 8 Feb 2021 16:30:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232126AbhBHUeE (ORCPT ); Mon, 8 Feb 2021 15:34:04 -0500 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1634EC061788 for ; Mon, 8 Feb 2021 12:33:24 -0800 (PST) Received: by mail-pg1-x532.google.com with SMTP id g15so10994392pgu.9 for ; Mon, 08 Feb 2021 12:33:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8sJIQ7ey27vDjxSf7LzfXss7hIpoO6CjdEZcKguBnkA=; b=h3RNQULLGURi8yuzfdjwbFZqCfrh+rDTOBd9SBVVDSi9380NzoAY0IFRRzxT+Gp7y0 EyUSBW/+WypeEPREZYoNZd2lWpVhxNKpVcCKjRXJDy7McP9CkyzOM6HBCjZWWWpYXS95 WZbMRqcZj2na+9d8O1/A54CDB7d/mwskrmZ6MCkIAXTs2va5ZiT5AzEwXftCyAVd9OU1 uRUB5KAUAkgXY19O0H1r3OJG7ORX8REnyZnSqTOhpg7Djnj43vDov/Pot4R1bUP4UkZ2 HOBXQKQitSA4BI5I8XV9EvZMOTofQchX/xotG2WLNWAa/AjC0V4enhyDURX+u+A3yW8y tB0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8sJIQ7ey27vDjxSf7LzfXss7hIpoO6CjdEZcKguBnkA=; b=nuk0fCetnZ1cUIaJ451rKOmcV2cGwT9Lyc0PNPRJ584ufhxNINnlO577dgQQXUc5Ww o0ThdEgmzc+sQbRZm2j66roL3Bnwk+IUk8Ml7KQgiZicbth/Qhy654LQTVCwG+Lix0sV vXB3h9i9EaQfzY0l4aOfQSwLGSzs/b0oHdrtPfrZFJZnV28P2PKqTJY+o7+w6aMZifPv KeUO9pdxoM5X19U24hmj86HOVbDx/30iuUiOfI23y2xr/IhYdNVRv7vt8r+nVx6x1ykb oEpTjlKiQ/cpvRwO4963KmPLrQMMcItwDEXbO7qiFUjICXzEo8JECcg7RXYzV9WXkqkn mDag== X-Gm-Message-State: AOAM532O08yZW7RrynrabJD9ALLfVR/RgOVnVZYL9lycMHRH04k4W7hu 9MparqCQp0EKclhiLAN8mAcMlg== X-Google-Smtp-Source: ABdhPJwZWqP1nruXuIblgbD06iE4nLs4M/qFajWrDEpl8V+m7W81StVvNA6e1oO24SKw+JDHL5P7BQ== X-Received: by 2002:a63:7c5:: with SMTP id 188mr18525532pgh.22.1612816403603; Mon, 08 Feb 2021 12:33:23 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id 143sm130781pfw.3.2021.02.08.12.33.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 12:33:23 -0800 (PST) Date: Mon, 8 Feb 2021 13:33:20 -0700 From: Mathieu Poirier To: Leo Yan Cc: Arnaldo Carvalho de Melo , Suzuki K Poulose , Mike Leach , Jonathan Corbet , John Garry , Will Deacon , Peter Zijlstra , Ingo Molnar , Mark Rutland , Jiri Olsa , Namhyung Kim , Daniel Kiss , Denis Nikitin , Al Grant , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 7/8] perf cs-etm: Detect pid in VMID for kernel running at EL2 Message-ID: <20210208203320.GD2077938@xps15> References: <20210206150833.42120-1-leo.yan@linaro.org> <20210206150833.42120-8-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210206150833.42120-8-leo.yan@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 06, 2021 at 11:08:32PM +0800, Leo Yan wrote: > From: Suzuki K Poulose > > The PID of the task could be traced as VMID when the kernel is running > at EL2. Teach the decoder to look for VMID when the CONTEXTIDR (Arm32) > or CONTEXTIDR_EL1 (Arm64) is invalid but we have a valid VMID. > > Cc: Mike Leach > Cc: Mathieu Poirier > Cc: Al Grant > Signed-off-by: Suzuki K Poulose > Co-developed-by: Leo Yan > Signed-off-by: Leo Yan Reviewed-by: Mathieu Poirier > --- > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 38 +++++++++++++++++-- > 1 file changed, 34 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > index 3f4bc4050477..4052c9ce6e2f 100644 > --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > @@ -6,6 +6,7 @@ > * Author: Mathieu Poirier > */ > > +#include > #include > #include > #include > @@ -491,13 +492,42 @@ cs_etm_decoder__set_tid(struct cs_etm_queue *etmq, > const ocsd_generic_trace_elem *elem, > const uint8_t trace_chan_id) > { > - pid_t tid; > + pid_t tid = -1; > + static u64 pid_fmt; > + int ret; > > - /* Ignore PE_CONTEXT packets that don't have a valid contextID */ > - if (!elem->context.ctxt_id_valid) > + /* > + * As all the ETMs run at the same exception level, the system should > + * have the same PID format crossing CPUs. So cache the PID format > + * and reuse it for sequential decoding. > + */ > + if (!pid_fmt) { > + ret = cs_etm__get_pid_fmt(trace_chan_id, &pid_fmt); > + if (ret) > + return OCSD_RESP_FATAL_SYS_ERR; > + } > + > + /* > + * Process the PE_CONTEXT packets if we have a valid contextID or VMID. > + * If the kernel is running at EL2, the PID is traced in CONTEXTIDR_EL2 > + * as VMID, Bit ETM_OPT_CTXTID2 is set in this case. > + */ > + switch (pid_fmt) { > + case BIT(ETM_OPT_CTXTID): > + if (elem->context.ctxt_id_valid) > + tid = elem->context.context_id; > + break; > + case BIT(ETM_OPT_CTXTID2): > + if (elem->context.vmid_valid) > + tid = elem->context.vmid; > + break; > + default: > + break; > + } > + > + if (tid == -1) > return OCSD_RESP_CONT; > > - tid = elem->context.context_id; > if (cs_etm__etmq_set_tid(etmq, tid, trace_chan_id)) > return OCSD_RESP_FATAL_SYS_ERR; > > -- > 2.25.1 >