From: Ioana Ciornei <ioana.ciornei@nxp.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ioana Ciornei <ciorneiioana@gmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] bus: fsl-mc: Fix test for end of loop
Date: Tue, 9 Feb 2021 09:17:07 +0000 [thread overview]
Message-ID: <20210209091706.ug7cjdn5rripnqv7@skbuf> (raw)
In-Reply-To: <20210208185810.GM20820@kadam>
On Mon, Feb 08, 2021 at 09:58:10PM +0300, Dan Carpenter wrote:
> On Mon, Feb 08, 2021 at 07:09:47PM +0200, Ioana Ciornei wrote:
> > From: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > The "desc" pointer can't possibly be NULL here. If we can't find the
> > correct "desc" then tt points to the last element of the
> > fsl_mc_accepted_cmds[] array. Fix this by testing if
> > "i == FSL_MC_NUM_ACCEPTED_CMDS" instead.
> >
> > Fixes: 2cf1e703f066 ("bus: fsl-mc: add fsl-mc userspace support")
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Generally the tags are expected to go in chronological order:
>
> Fixes: commit
> Signed-off-by: Author
> Acked-by: Whoever
> Signed-off-by: Maintainer
>
Thanks! I didn't know that.
Ioana
next prev parent reply other threads:[~2021-02-09 9:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 17:09 [PATCH 0/3] bus: fsl-mc: minor updates Ioana Ciornei
2021-02-08 17:09 ` [PATCH 1/3] bus: fsl-mc: Fix test for end of loop Ioana Ciornei
2021-02-08 18:58 ` Dan Carpenter
2021-02-09 9:17 ` Ioana Ciornei [this message]
2021-02-08 17:09 ` [PATCH 2/3] bus: fsl-mc: add the dpdbg device type Ioana Ciornei
2021-02-08 17:09 ` [PATCH 3/3] bus: fsl-mc: list more commands as accepted through the ioctl Ioana Ciornei
2021-02-08 18:26 ` [PATCH 0/3] bus: fsl-mc: minor updates Laurentiu Tudor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209091706.ug7cjdn5rripnqv7@skbuf \
--to=ioana.ciornei@nxp.com \
--cc=ciorneiioana@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®