From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67D79C433E0 for ; Wed, 10 Feb 2021 00:54:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EE7464E58 for ; Wed, 10 Feb 2021 00:54:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234116AbhBJAxy (ORCPT ); Tue, 9 Feb 2021 19:53:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:55452 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233983AbhBIWMQ (ORCPT ); Tue, 9 Feb 2021 17:12:16 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 83C3264EDB; Tue, 9 Feb 2021 21:58:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1612907919; bh=3OazZLnMyWfzCFzoLzcmJx+KxLTa7Ra6qrPelD5PAJc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=l4OVeW6UO3eZoL6HdhnLEntkfsJha1QB0Hp3JUXgAmjhCkCRQJbRtIuNUfAopYcAP iKHbxIeIejc4/QlW3XVUd6L0ItJLgOIunN9QXjyxizis4aHpxAoUSnVS4gKGlKYZHi SyxhdbawLDcAUoTnpY4g/cvV9GR6ocECy3THL5A0= Date: Tue, 9 Feb 2021 13:58:37 -0800 From: Andrew Morton To: Ira Weiny Cc: dsterba@suse.cz, clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH 0/4] btrfs: Convert kmaps to core page calls Message-Id: <20210209135837.055cfd1df4e5829f2da6b062@linux-foundation.org> In-Reply-To: <20210209215229.GC2975576@iweiny-DESK2.sc.intel.com> References: <20210205232304.1670522-1-ira.weiny@intel.com> <20210209151123.GT1993@suse.cz> <20210209110931.00f00e47d9a0529fcee2ff01@linux-foundation.org> <20210209205249.GB2975576@iweiny-DESK2.sc.intel.com> <20210209131103.b46e80db675fec8bec8d2ad1@linux-foundation.org> <20210209215229.GC2975576@iweiny-DESK2.sc.intel.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 9 Feb 2021 13:52:29 -0800 Ira Weiny wrote: > > > > Let's please queue this up separately. > > Ok can I retain your Ack on the move part of the patch? I missed that. > Note that it does change kmap_atomic() to kmap_local_page() currently. > > Would you prefer a separate change for that as well? Really that should be separated out as well, coming after the move, to make it more easily reverted. With a standalone changlog for this. All a bit of a pain, but it's best in the long run.