From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EE19C433E0 for ; Tue, 9 Feb 2021 16:16:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D8AD64DBD for ; Tue, 9 Feb 2021 16:16:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231249AbhBIQPp (ORCPT ); Tue, 9 Feb 2021 11:15:45 -0500 Received: from mx2.suse.de ([195.135.220.15]:49338 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232198AbhBIQPQ (ORCPT ); Tue, 9 Feb 2021 11:15:16 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5A610AD2E; Tue, 9 Feb 2021 16:14:34 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 2F430DA7C8; Tue, 9 Feb 2021 17:12:41 +0100 (CET) Date: Tue, 9 Feb 2021 17:12:41 +0100 From: David Sterba To: Pan Bian Cc: David Sterba , Fabian Frederick , Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/affs: release old buffer head on error path Message-ID: <20210209161240.GV1993@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Pan Bian , David Sterba , Fabian Frederick , Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210120085113.118984-1-bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210120085113.118984-1-bianpan2016@163.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2021 at 12:51:13AM -0800, Pan Bian wrote: > The reference count of the old buffer head should be decremented on path > that fails to get the new buffer head. > > Fixes: 6b4657667ba0 ("fs/affs: add rename exchange") > Signed-off-by: Pan Bian Thanks, added to affs branch. The fix is not that urgent for 5.11 so I'll send it for the 5.12 merge window. I've added the stable tag so it'll propagate to 4.14+.