From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2726C433E0 for ; Wed, 10 Feb 2021 13:30:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D9C864E77 for ; Wed, 10 Feb 2021 13:30:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230267AbhBJNaV (ORCPT ); Wed, 10 Feb 2021 08:30:21 -0500 Received: from mail.skyhub.de ([5.9.137.197]:56348 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229465AbhBJNaP (ORCPT ); Wed, 10 Feb 2021 08:30:15 -0500 Received: from zn.tnic (p200300ec2f037400315ea78552594295.dip0.t-ipconnect.de [IPv6:2003:ec:2f03:7400:315e:a785:5259:4295]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2BC3F1EC04A9; Wed, 10 Feb 2021 14:29:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1612963771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=5alnFyQqfewF64h4BDFj4Y6OzUELAoQQee6RKH78b38=; b=ETRoW+2aEhtNAAnK6ndPfin9XSbWzlEFbMwFZvbpz58zKfvMI65k8/nhzPk644m3RbKNl6 Jrn6AZy22YRmZiz4JWCh20yb9I063RJQiAqTqew00xvcE+/SYjga05tjDg2oNsrLJisJNm P8ElG4uPcI8E4jHVfW53OcNrnhUdWaQ= Date: Wed, 10 Feb 2021 14:29:28 +0100 From: Borislav Petkov To: Andy Lutomirski Cc: X86 ML , LKML , Dave Hansen , Alexei Starovoitov , Daniel Borkmann , Yonghong Song , Masami Hiramatsu Subject: Re: [PATCH v2 08/14] x86/fault: Skip erratum #93 workaround on new CPUs Message-ID: <20210210132928.GB14650@zn.tnic> References: <8969c688ee663e99901cf4b0383bc6662ce79707.1612924255.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 09, 2021 at 10:06:02PM -0800, Andy Lutomirski wrote: > On Tue, Feb 9, 2021 at 6:33 PM Andy Lutomirski wrote: > > > > Erratum #93 applies to the first generation of AMD K8 CPUs. Skip the > > workaround on newer CPUs. > > Whoops, this breaks the !CPU_SUP_AMD build. It needs a fixup like this: > > https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/fault&id=06772a3b6918bf6d6d0778946149b7d56ae30d80 > > Boris, do you want a v3? Do we even want to apply patch 8 at all? This has always ran on K8 NPT CPUs too and those are pretty much obsolete by now so I'm thinking, leave sleeping dogs lie...? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette