From: David Miller <davem@davemloft.net>
To: nobuhiro1.iwamatsu@toshiba.co.jp
Cc: kuba@kernel.org, robh+dt@kernel.org, peppe.cavallaro@st.com,
alexandre.torgue@st.com, joabreu@synopsys.com,
punit1.agrawal@toshiba.co.jp, yuji2.ishikawa@toshiba.co.jp,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver
Date: Thu, 11 Feb 2021 14:13:07 -0800 (PST) [thread overview]
Message-ID: <20210211.141307.764092492929918552.davem@davemloft.net> (raw)
In-Reply-To: <20210210162954.3955785-3-nobuhiro1.iwamatsu@toshiba.co.jp>
From: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Date: Thu, 11 Feb 2021 01:29:52 +0900
> +static int visconti_eth_init_hw(struct platform_device *pdev, struct plat_stmmacenet_data *plat_dat)
> +{
> + struct visconti_eth *dwmac;
> + unsigned int reg_val, clk_sel_val;
Please use reverse christmas tree ordering for local variable declarations.
> +static int visconti_eth_clock_probe(struct platform_device *pdev,
> + struct plat_stmmacenet_data *plat_dat)
> +{
> + int err;
> + struct visconti_eth *dwmac;
Likewise.
> +static int visconti_eth_clock_remove(struct platform_device *pdev)
> +{
> + struct net_device *ndev = platform_get_drvdata(pdev);
> + struct stmmac_priv *priv = netdev_priv(ndev);
> + struct visconti_eth *dwmac = get_stmmac_bsp_priv(&pdev->dev);
Likewise.
Thanks.
next prev parent reply other threads:[~2021-02-11 22:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 16:29 [PATCH 0/4] " Nobuhiro Iwamatsu
2021-02-10 16:29 ` [PATCH 1/4] dt-bindings: net: Add DT bindings for Toshiba Visconti TMPV7700 SoC Nobuhiro Iwamatsu
2021-02-10 16:29 ` [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver Nobuhiro Iwamatsu
2021-02-11 22:13 ` David Miller [this message]
2021-02-12 0:29 ` Nobuhiro Iwamatsu
2021-02-10 16:29 ` [PATCH 3/4] MAINTAINERS: Add entries for Toshiba Visconti ethernet controller Nobuhiro Iwamatsu
2021-02-10 16:29 ` [PATCH 4/4] arm: dts: visconti: Add DT support for Toshiba Visconti5 " Nobuhiro Iwamatsu
2021-02-15 5:06 [PATCH v3 0/4] net: stmmac: Add Toshiba Visconti SoCs glue driver Nobuhiro Iwamatsu
2021-02-15 5:06 ` [PATCH 2/4] " Nobuhiro Iwamatsu
2021-02-15 6:07 ` Leon Romanovsky
2021-02-15 7:28 ` Nobuhiro Iwamatsu
2021-02-15 9:22 ` Leon Romanovsky
2021-02-15 12:19 ` Arnd Bergmann
2021-02-15 15:20 ` Nobuhiro Iwamatsu
2021-02-15 15:14 ` Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211.141307.764092492929918552.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=peppe.cavallaro@st.com \
--cc=punit1.agrawal@toshiba.co.jp \
--cc=robh+dt@kernel.org \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®