From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE52AC433E0 for ; Wed, 10 Feb 2021 21:14:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93F6C64E31 for ; Wed, 10 Feb 2021 21:14:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233746AbhBJVOC (ORCPT ); Wed, 10 Feb 2021 16:14:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232804AbhBJVKW (ORCPT ); Wed, 10 Feb 2021 16:10:22 -0500 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94271C0613D6; Wed, 10 Feb 2021 13:09:41 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4DbXSx6ckVz9sRf; Thu, 11 Feb 2021 08:09:37 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1612991378; bh=T37OReoOydFbq4unal8lMB7zx6wTkEScGSNlSPw6ilw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Au/K03MmTWDwkNwgXpRYwXzNdKD5CLmWC9iMkxqcsCtod8qCqUNeZ83ml6swojmRW rorY8TZinRrvQAMGvGGqJByedWFJdW2tfwYh8U/M5NH3F9i/abWsaJZZAN2RCGKrzS loPz7nQQPlsXJdu7MKck6V0445fwIM/EpHtG/+04N+bv2wK+FvkvC04HYA8mGzopbd 2xqVAANOtZn31q610PlpEyAtCIVMzdTrSFGYmgY5Bq6kXQtDPM71q/bCZ20nWdSPTO 0rRKjMV3biyw+dpGji5F9UnYndc+i4AbvkFRrhfKoZjUa5k5+G9CIMLaQxKcFMh+16 GJemgs/eqze2A== Date: Thu, 11 Feb 2021 08:09:36 +1100 From: Stephen Rothwell To: Saravana Kannan Cc: Rob Herring , Frank Rowand , Greg Kroah-Hartman , kernel-team@android.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] of: irq: Fix the return value for of_irq_parse_one() stub Message-ID: <20210211080936.7c51b99c@canb.auug.org.au> In-Reply-To: <20210210200050.4106032-1-saravanak@google.com> References: <20210210200050.4106032-1-saravanak@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/9VHlBQTTpR8AbkOIrHYbqOp"; protocol="application/pgp-signature"; micalg=pgp-sha256 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/9VHlBQTTpR8AbkOIrHYbqOp Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Saravana, On Wed, 10 Feb 2021 12:00:49 -0800 Saravana Kannan w= rote: > > When commit 1852ebd13542 ("of: irq: make a stub for of_irq_parse_one()") > added a stub for of_irq_parse_one() it set the return value to 0. Return > value of 0 in this instance means the call succeeded and the out_irq > pointer was filled with valid data. So, fix it to return an error value. >=20 > Fixes: 1852ebd13542 ("of: irq: make a stub for of_irq_parse_one()") > Signed-off-by: Saravana Kannan Oops, sorry about that. Acked-by: Stephen Rothwell --=20 Cheers, Stephen Rothwell --Sig_/9VHlBQTTpR8AbkOIrHYbqOp Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmAkS5AACgkQAVBC80lX 0GwRCQf9EBXY8yx+s8dTbRHzyMaTzfcM8yWhayyA+gpPCBRi2K98HHe7Ru+ayJVP u/YA78f3rJAG9IRa6EfZNGPRvZMeEJRuK1QuRdXX9CpMOXx3TIEbHTZI7cD6bpCk n7VQpyWKB1tZV4SEC/UYofIZB+R3mgdn/6xGS16oMvLrwE4UEiMBRUeq9may8pia hKe/K6/Tg0a3owfPw7JvLtIiAA9qQiCo9VAGV3y/35Jlu3+Ht5IA+YT1m99ljVxd c5wFitjJNPdLSyYCIzv0cmbuBjwzWnlhrWz0G3oVq9OchSGyJnwciiOgZT2Mp6Wx 1ULk877lV3YLLd6Xj8RevOxm7lzibw== =ddxf -----END PGP SIGNATURE----- --Sig_/9VHlBQTTpR8AbkOIrHYbqOp--