From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED496C433DB for ; Fri, 12 Feb 2021 21:09:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE18364DEC for ; Fri, 12 Feb 2021 21:09:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232005AbhBLVJD (ORCPT ); Fri, 12 Feb 2021 16:09:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:58732 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231289AbhBLVI6 (ORCPT ); Fri, 12 Feb 2021 16:08:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0CAEE601FF; Fri, 12 Feb 2021 21:08:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1613164097; bh=TshSgO+ebZMoA2lgK0wETLr/ZM7OS4W2rKQLUJLiZOU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dU5l63E+JgxMA9hCk/3yD9QdirwmUXp/uYUF/gEWBBbbw6aFNgKIWCCg8n7d9iNNh xIokgctQ+x5kt8jukAVR82rLaJELRFGZ940HgrgWFfqL+372qV9zOpCQ3jCpX4vpsx 0hLdVCahws96UqaUmfsgjYBkWnBv4Yf5GBg//51o= Date: Fri, 12 Feb 2021 13:08:16 -0800 From: Andrew Morton To: Andrey Konovalov Cc: Catalin Marinas , Vincenzo Frascino , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Christoph Hellwig , kasan-dev , Linux ARM , Linux Memory Management List , LKML Subject: Re: [PATCH mm] kasan: export HW_TAGS symbols for KUnit tests Message-Id: <20210212130816.cde26643a6b9b24007be4e54@linux-foundation.org> In-Reply-To: References: <20210212121610.ff05a7bb37f97caef97dc924@linux-foundation.org> <20210212125454.b660a3bf3e9945515f530066@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Feb 2021 22:01:38 +0100 Andrey Konovalov wrote: > On Fri, Feb 12, 2021 at 9:54 PM Andrew Morton wrote: > > > > On Fri, 12 Feb 2021 21:21:39 +0100 Andrey Konovalov wrote: > > > > > > > The wrappers aren't defined when tests aren't enabled to avoid misuse. > > > > > The mte_() functions aren't exported directly to avoid having low-level > > > > > KASAN ifdefs in the arch code. > > > > > > > > > > > > > Please confirm that this is applicable to current Linus mainline? > > > > > > It's not applicable. KUnit tests for HW_TAGS aren't supported there, > > > the patches for that are in mm only. So no need to put it into 5.11. > > > > So... which -mm patch does this patch fix? > > "kasan, arm64: allow using KUnit tests with HW_TAGS mode". > > There will be some minor adjacent-line-changed conflicts if you decide > to squash it. > > Alternatively, this can go as a separate patch after the tests series > (after "kasan: don't run tests when KASAN is not enabled"). Thanks - it wasn't obvious. I staged it as a fix against "kasan, arm64: allow using KUnit tests with HW_TAGS mode". To make the series as nice as we can, and to avoid bisection holes.