From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8618AC433E0 for ; Fri, 12 Feb 2021 16:37:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F5AD64E76 for ; Fri, 12 Feb 2021 16:37:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230125AbhBLQhG (ORCPT ); Fri, 12 Feb 2021 11:37:06 -0500 Received: from elvis.franken.de ([193.175.24.41]:51425 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230199AbhBLQej (ORCPT ); Fri, 12 Feb 2021 11:34:39 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lAbO7-00056D-00; Fri, 12 Feb 2021 17:33:47 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 183D4C0E7B; Fri, 12 Feb 2021 17:33:35 +0100 (CET) Date: Fri, 12 Feb 2021 17:33:35 +0100 From: Thomas Bogendoerfer To: Tiezhu Yang Cc: Oleg Nesterov , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Xuefeng Li , kernel test robot , Xingxing Su Subject: Re: [PATCH v2] MIPS: Add basic support for ptrace single step Message-ID: <20210212163335.GA12558@alpha.franken.de> References: <1612939961-8827-1-git-send-email-yangtiezhu@loongson.cn> <20210211102905.GE7985@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210211102905.GE7985@alpha.franken.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2021 at 11:29:05AM +0100, Thomas Bogendoerfer wrote: > IMHO ptrace single step is for CPUs supporting single stepping and not > for emulating it in the kernel. I've checked other arch how they implement single step, and looks like I'm wrong. So I'm ok with applying your patch. Can you resend it again, so I'll get the latest version in patchwork ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]