From: Diego Viola <diego.viola@gmail.com>
To: bskeggs@redhat.com
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
nouveau@spliet.org, gnurou@gmail.com,
Diego Viola <diego.viola@gmail.com>
Subject: [PATCH] drm/nouveau/pmu: fix timeout on GP108
Date: Sun, 14 Feb 2021 02:03:09 -0300 [thread overview]
Message-ID: <20210214050309.2395-1-diego.viola@gmail.com> (raw)
This code times out on GP108, probably because the BIOS puts it into a
bad state.
Since we reset the PMU on driver load anyway, we are at no risk from
missing a response from it since we are not waiting for one to begin
with.
Signed-off-by: Diego Viola <diego.viola@gmail.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/pmu/base.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/base.c
index a0fe607c9c07..4f02c4f14f04 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/base.c
@@ -104,10 +104,6 @@ nvkm_pmu_reset(struct nvkm_pmu *pmu)
/* Inhibit interrupts, and wait for idle. */
nvkm_wr32(device, 0x10a014, 0x0000ffff);
- nvkm_msec(device, 2000,
- if (!nvkm_rd32(device, 0x10a04c))
- break;
- );
/* Reset. */
if (pmu->func->reset)
--
2.30.1
reply other threads:[~2021-02-14 5:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210214050309.2395-1-diego.viola@gmail.com \
--to=diego.viola@gmail.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gnurou@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@spliet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®