From: kernel test robot <lkp@intel.com>
To: Ansuel Smith <ansuelsmth@gmail.com>, Richard Weinberger <richard@nod.at>
Cc: kbuild-all@lists.01.org, Ansuel Smith <ansuelsmth@gmail.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Boris Brezillon <bbrezillon@kernel.org>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] mtd: core: add nvmem-partitions compatible to parse mtd as nvmem cells
Date: Wed, 17 Feb 2021 05:10:36 +0800 [thread overview]
Message-ID: <202102170515.k8rPTcor-lkp@intel.com> (raw)
In-Reply-To: <20210216195618.27959-3-ansuelsmth@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3068 bytes --]
Hi Ansuel,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mtd/mtd/next]
[also build test ERROR on mtd/mtd/fixes robh/for-next v5.11 next-20210216]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Ansuel-Smith/Implement-nvmem-support-for-mtd/20210217-035931
base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
config: m68k-randconfig-r011-20210216 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ea1902bc853fa1f1050cc741912709fe5ebbdc41
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ansuel-Smith/Implement-nvmem-support-for-mtd/20210217-035931
git checkout ea1902bc853fa1f1050cc741912709fe5ebbdc41
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/mtd/mtdcore.c: In function 'mtd_nvmem_add':
>> drivers/mtd/mtdcore.c:546:47: error: 'node' undeclared (first use in this function); did you mean 'inode'?
546 | config.no_of_node = !of_device_is_compatible(node, "nvmem-partitions");
| ^~~~
| inode
drivers/mtd/mtdcore.c:546:47: note: each undeclared identifier is reported only once for each function it appears in
vim +546 drivers/mtd/mtdcore.c
531
532 static int mtd_nvmem_add(struct mtd_info *mtd)
533 {
534 struct nvmem_config config = {};
535
536 config.id = -1;
537 config.dev = &mtd->dev;
538 config.name = dev_name(&mtd->dev);
539 config.owner = THIS_MODULE;
540 config.reg_read = mtd_nvmem_reg_read;
541 config.size = mtd->size;
542 config.word_size = 1;
543 config.stride = 1;
544 config.read_only = true;
545 config.root_only = true;
> 546 config.no_of_node = !of_device_is_compatible(node, "nvmem-partitions");
547 config.priv = mtd;
548
549 mtd->nvmem = nvmem_register(&config);
550 if (IS_ERR(mtd->nvmem)) {
551 /* Just ignore if there is no NVMEM support in the kernel */
552 if (PTR_ERR(mtd->nvmem) == -EOPNOTSUPP) {
553 mtd->nvmem = NULL;
554 } else {
555 dev_err(&mtd->dev, "Failed to register NVMEM device\n");
556 return PTR_ERR(mtd->nvmem);
557 }
558 }
559
560 return 0;
561 }
562
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 22660 bytes --]
next prev parent reply other threads:[~2021-02-16 21:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 19:56 [PATCH 0/3] Implement nvmem support for mtd Ansuel Smith
2021-02-16 19:56 ` [PATCH 1/3] mtd: partitions: ofpart: skip subnodes parse with compatible Ansuel Smith
2021-02-16 19:56 ` [PATCH 2/3] mtd: core: add nvmem-partitions compatible to parse mtd as nvmem cells Ansuel Smith
2021-02-16 21:10 ` kernel test robot [this message]
2021-02-16 19:56 ` [PATCH 3/3] dt-bindings: mtd: Document use of nvmem-partitions compatible Ansuel Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102170515.k8rPTcor-lkp@intel.com \
--to=lkp@intel.com \
--cc=ansuelsmth@gmail.com \
--cc=bbrezillon@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®